Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling

2016-08-16 Thread Thomas Schwinge
Hi! On Mon, 15 Aug 2016 18:54:49 -0700, Cesar Philippidis wrote: > For the moment, I'm ignoring the > device_type problem and handling all of the matching errors in > gfc_match_oacc_routine. OK for the moment; my idea has been to do it generally enough already now, using generic infrastructure

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling

2016-08-15 Thread Cesar Philippidis
On 08/11/2016 09:26 AM, Thomas Schwinge wrote: > As Cesar asked for it, there is now a Git branch > tschwinge/omp/pr72741-wip containing these changes (plus some other > pending changes that I didn't single out at this time), at >

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling

2016-08-11 Thread Cesar Philippidis
On 08/11/2016 08:18 AM, Thomas Schwinge wrote: >> --- a/gcc/fortran/module.c >> +++ b/gcc/fortran/module.c > >> [...] >> +DECL_MIO_NAME (oacc_function) >> [...] > > As discussed between Cesar and Tobias, these module.c/symbol.c changes > introduce an incompatibility in the Fortran module file

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Jakub Jelinek
On Thu, Aug 11, 2016 at 06:26:50PM +0200, Thomas Schwinge wrote: > > > --- gcc/fortran/gfortran.h > > > +++ gcc/fortran/gfortran.h > > > > /* Symbol attribute structure. */ > > > -typedef struct > > > +typedef struct symbol_attribute > > > { > > > While symbol_attribute is already bloated, I d

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Thomas Schwinge
Hi! As Cesar asked for it, there is now a Git branch tschwinge/omp/pr72741-wip containing these changes (plus some other pending changes that I didn't single out at this time), at . (I expect it does, but I didn'

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Jakub Jelinek
On Thu, Aug 11, 2016 at 05:18:43PM +0200, Thomas Schwinge wrote: > --- gcc/fortran/gfortran.h > +++ gcc/fortran/gfortran.h > @@ -729,7 +839,7 @@ ext_attr_t; > extern const ext_attr_t ext_attr_list[]; > > /* Symbol attribute structure. */ > -typedef struct > +typedef struct symbol_attribute >