Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Andrea Parri
On Fri, May 05, 2023 at 02:42:38PM -0700, Hans Boehm wrote: > I think A.6-tso also needs to change the last line in the table from > lr.aqrl ... sc to lr.aq ... sc.rl, otherwise I think we have problems with > a subsequent A.7-tso generated l.aq . Otherwise I agree. Indeed! Thanks for the correct

Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Andrew Waterman via Gcc-patches
On Fri, May 5, 2023 at 2:42 PM Hans Boehm wrote: > > I think A.6-tso also needs to change the last line in the table from lr.aqrl > ... sc to lr.aq ... sc.rl, otherwise I think we have problems with a > subsequent A.7-tso generated l.aq . Otherwise I agree. > > I certainly agree that, given the

Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Hans Boehm via Gcc-patches
I think A.6-tso also needs to change the last line in the table from lr.aqrl ... sc to lr.aq ... sc.rl, otherwise I think we have problems with a subsequent A.7-tso generated l.aq . Otherwise I agree. I certainly agree that, given the Ztso extension, there should be a standard compiler-implemented

Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Andrea Parri
On Fri, May 05, 2023 at 12:18:12PM -0700, Palmer Dabbelt wrote: > On Fri, 05 May 2023 11:55:31 PDT (-0700), Andrea Parri wrote: > > On Fri, May 05, 2023 at 10:12:56AM -0700, Patrick O'Neill wrote: > > > The RISC-V Ztso extension currently has no effect on generated code. > > > With the additional o

Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Palmer Dabbelt
On Fri, 05 May 2023 11:55:31 PDT (-0700), Andrea Parri wrote: On Fri, May 05, 2023 at 10:12:56AM -0700, Patrick O'Neill wrote: The RISC-V Ztso extension currently has no effect on generated code. With the additional ordering constraints guarenteed by Ztso, we can emit more optimized atomic mappi

Re: [RFC] RISC-V: Add proposed Ztso atomic mappings

2023-05-05 Thread Andrea Parri
On Fri, May 05, 2023 at 10:12:56AM -0700, Patrick O'Neill wrote: > The RISC-V Ztso extension currently has no effect on generated code. > With the additional ordering constraints guarenteed by Ztso, we can emit > more optimized atomic mappings than the RVWMO mappings. > > This patch implements And