Re: [RFC][PATCH] RL78 - clean-up of missing operand mode warnings.

2014-04-17 Thread DJ Delorie
> It seems a little inconsistent, however, that *movqi_real and > *xorqi3_real don't specify modes but *movhi_real and > *andqi_real/*iorqi_real do (and they also accept CONST_INTs). Not that > I'm advocating generating more warnings, but my inner OCD likes > consistency :) Adding the mode m

Re: [RFC][PATCH] RL78 - clean-up of missing operand mode warnings.

2014-04-17 Thread Richard Hulme
On 15/04/14 22:58, DJ Delorie wrote: I typically leave the mode off when the operand accepts a CONST_INT as I've had problems with patterns matching CONST_INTs otherwise, as CONST_INT rtx's do not have a mode (or have VOIDmode). (yes, I know gcc is supposed to accomodate that, but like I said, I

Re: [RFC][PATCH] RL78 - clean-up of missing operand mode warnings.

2014-04-15 Thread DJ Delorie
I typically leave the mode off when the operand accepts a CONST_INT as I've had problems with patterns matching CONST_INTs otherwise, as CONST_INT rtx's do not have a mode (or have VOIDmode). (yes, I know gcc is supposed to accomodate that, but like I said, I've had problems...)