Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter

2015-02-24 Thread Thomas Schwinge
Hi! On Fri, 16 Jan 2015 21:34:15 +0100, I wrote: > On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > > In r219682, I have committed to trunk our current set of OpenACC changes, > > Here is a patch to remove the __OFFLOAD_SYMBOL__ variable/formal > parameter, as discussed in

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
Confirmed that this patch eliminates [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin and thus exposes [Bug libgomp/64635] New: darwin produces libgomp-plugin-host_nonshm.1.dylib but tries to load libgomp-plugin-host_nonshm.so.1 The additional hack (which should be fi

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Ilya Verbin
On 16 Jan 19:23, Jack Howarth wrote: > As I read https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625#c3, the > requirement for __OFFLOAD_TABLE__ was not longer present and the > residual usages of it just had to be removed. The weak symbol on > darwin is fragile and seems to trip up on the existing

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
As I read https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625#c3, the requirement for __OFFLOAD_TABLE__ was not longer present and the residual usages of it just had to be removed. The weak symbol on darwin is fragile and seems to trip up on the existing code which produces undefined symbols for __

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Ilya Verbin
On 16 Jan 18:22, Jack Howarth wrote: > On 86_64 Fedora 15, current gcc trunk only produces… > > nm libgcc_s.so.1 | grep OFF > 00215478 d _GLOBAL_OFFSET_TABLE_ > > and not __OFFLOAD_TABLE__, The libgcc_s.so.1 built on > x86_64-apple-darwin14 doesn't even contain the _GLOBAL_OFFSET_TABLE_

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
On 86_64 Fedora 15, current gcc trunk only produces… nm libgcc_s.so.1 | grep OFF 00215478 d _GLOBAL_OFFSET_TABLE_ and not __OFFLOAD_TABLE__, The libgcc_s.so.1 built on x86_64-apple-darwin14 doesn't even contain the _GLOBAL_OFFSET_TABLE_ symbol. On Fri, Jan 16, 2015 at 5:40 PM, Ilya Ver

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Ilya Verbin
On 16 Jan 21:34, Thomas Schwinge wrote: > On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > Here is a patch to remove the __OFFLOAD_SYMBOL__ variable/formal > parameter, as discussed in . > > But -- I now wonder whether that's actually the issue that has been > reported i