Re: [PR c++/84593] ice on braced init with uninit ref field

2018-03-06 Thread Jason Merrill
On Tue, Mar 6, 2018 at 12:42 AM, Alexandre Oliva wrote: > On Mar 2, 2018, Jason Merrill wrote: > >> On Fri, Mar 2, 2018 at 2:57 AM, Alexandre Oliva wrote: >>> + gcc_assert (TREE_CODE (type) == REFERENCE_TYPE); >>> + init = fold (convert (type, integer_zero_node)); > >> Maybe build_zer

Re: [PR c++/84593] ice on braced init with uninit ref field

2018-03-05 Thread Alexandre Oliva
On Mar 2, 2018, Jason Merrill wrote: >> + gcc_assert (TREE_CODE (type) == REFERENCE_TYPE); >> + init = fold (convert (type, integer_zero_node)); > Maybe build_zero_cst? > OK either way. Here's what I'm installing: [PR c++/84593] ice on braced init with uninit ref field If an initi

Re: [PR c++/84593] ice on braced init with uninit ref field

2018-03-05 Thread Alexandre Oliva
On Mar 2, 2018, Jason Merrill wrote: > On Fri, Mar 2, 2018 at 2:57 AM, Alexandre Oliva wrote: >> + gcc_assert (TREE_CODE (type) == REFERENCE_TYPE); >> + init = fold (convert (type, integer_zero_node)); > Maybe build_zero_cst? Sure. I wonder, is there any reason to not change any o

Re: [PR c++/84593] ice on braced init with uninit ref field

2018-03-02 Thread Jason Merrill
On Fri, Mar 2, 2018 at 2:57 AM, Alexandre Oliva wrote: > On Feb 28, 2018, Jason Merrill wrote: > >> On Wed, Feb 28, 2018 at 7:08 AM, Alexandre Oliva wrote: >>> Don't allow the initializer expr to be NULL in a ctor initializer >>> list, make it error_marker_node instead. > >> I don't want error_m

Re: [PR c++/84593] ice on braced init with uninit ref field

2018-03-01 Thread Alexandre Oliva
On Feb 28, 2018, Jason Merrill wrote: > On Wed, Feb 28, 2018 at 7:08 AM, Alexandre Oliva wrote: >> Don't allow the initializer expr to be NULL in a ctor initializer >> list, make it error_marker_node instead. > I don't want error_mark_nodes in a CONSTRUCTOR, either. When there > isn't an NSDMI

Re: [PR c++/84593] ice on braced init with uninit ref field

2018-02-28 Thread Jason Merrill
On Wed, Feb 28, 2018 at 7:08 AM, Alexandre Oliva wrote: > Don't allow the initializer expr to be NULL in a ctor initializer > list, make it error_marker_node instead. I don't want error_mark_nodes in a CONSTRUCTOR, either. When there isn't an NSDMI to worry about, we zero-initialize the referenc