Re: [PING][PATCH][2/2] Early LTO debug -- main part

2017-05-19 Thread Richard Biener
Late response now that I'm finished refreshing the patches. On Mon, Nov 28, 2016 at 6:20 PM, Jason Merrill wrote: > On Thu, Nov 24, 2016 at 8:50 AM, Richard Biener wrote: >>> > + /* ??? We can't annotate types late, but for LTO we may not >>> > +generate a location early either (gfortr

Re: [PING][PATCH][2/2] Early LTO debug -- main part

2016-11-28 Thread Jason Merrill
On Thu, Nov 24, 2016 at 8:50 AM, Richard Biener wrote: >> > + /* ??? We can't annotate types late, but for LTO we may not >> > +generate a location early either (gfortran.dg/save_5.f90). >> > +The proper way is to handle it like VLAs though it is told >> > +that DW_AT_string_leng

Re: [PING][PATCH][2/2] Early LTO debug -- main part

2016-11-24 Thread Richard Biener
On Thu, 24 Nov 2016, Richard Biener wrote: > On Tue, 22 Nov 2016, Jason Merrill wrote: > > > On 11/11/2016 03:06 AM, Richard Biener wrote: > > > +/* ??? In some cases the C++ FE (at least) fails to > > > + set DECL_CONTEXT properly. Simply globalize stuff > > > + in this case.

Re: [PING][PATCH][2/2] Early LTO debug -- main part

2016-11-24 Thread Richard Biener
On Tue, 22 Nov 2016, Jason Merrill wrote: > On 11/11/2016 03:06 AM, Richard Biener wrote: > > +/* ??? In some cases the C++ FE (at least) fails to > > + set DECL_CONTEXT properly. Simply globalize stuff > > + in this case. For example > > + __dso_handle created via iostrea

Re: [PING][PATCH][2/2] Early LTO debug -- main part

2016-11-22 Thread Jason Merrill
On 11/11/2016 03:06 AM, Richard Biener wrote: +/* ??? In some cases the C++ FE (at least) fails to + set DECL_CONTEXT properly. Simply globalize stuff + in this case. For example + __dso_handle created via iostream line 74 col 25. */ The comment for DECL_CONTEXT says t