Re: [PATCH v5 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2025-01-20 Thread Hongyu Wang
Richard Biener 于2025年1月20日周一 15:45写道: > > On Mon, 20 Jan 2025, Hongyu Wang wrote: > > > Thanks Richard for willing to review this part, it is true that the > > try_cmove_arith logic adds quite a lot of special handling for > > optimization, so I reduce the logic in emit_mask_load_store to just > >

Re: [PATCH v5 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2025-01-19 Thread Richard Biener
On Mon, 20 Jan 2025, Hongyu Wang wrote: > Thanks Richard for willing to review this part, it is true that the > try_cmove_arith logic adds quite a lot of special handling for > optimization, so I reduce the logic in emit_mask_load_store to just > generate most simple load/store that does not allow

Re: [PATCH v5 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2025-01-19 Thread Hongyu Wang
Thanks Richard for willing to review this part, it is true that the try_cmove_arith logic adds quite a lot of special handling for optimization, so I reduce the logic in emit_mask_load_store to just generate most simple load/store that does not allow sources to be swapped. Hi Jeff, would you help

Re: [PATCH v5 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2025-01-16 Thread Richard Sandiford
Hongyu Wang writes: > From: Lingling Kong > > Hi, > > Appreciated to Richard's review, the v5 patch contaings below change: > > 1. Separate the maskload/maskstore emit out from noce_emit_cmove, add > a new function emit_mask_load_store in optabs.cc. > 2. Follow the operand order of maskload and m