Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-04-02 Thread Sam James via Gcc-patches
Jeff Law writes: > On 4/2/23 14:06, Andrew Pinski wrote: >> On Sun, Apr 2, 2023 at 12:55 PM Jeff Law via Gcc-patches >> wrote: >>> >>> >>> >>> On 3/31/23 12:44, Sam James wrote: Kito Cheng writes: > It's not the RISC-V part, so this requires a global maintainer there I

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-04-02 Thread Andrew Pinski via Gcc-patches
On Sun, Apr 2, 2023 at 1:07 PM Jeff Law wrote: > > > > On 4/2/23 14:06, Andrew Pinski wrote: > > On Sun, Apr 2, 2023 at 12:55 PM Jeff Law via Gcc-patches > > wrote: > >> > >> > >> > >> On 3/31/23 12:44, Sam James wrote: > >>> > >>> Kito Cheng writes: > >>> > It's not the RISC-V part, so thi

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-04-02 Thread Jeff Law via Gcc-patches
On 4/2/23 14:06, Andrew Pinski wrote: On Sun, Apr 2, 2023 at 12:55 PM Jeff Law via Gcc-patches wrote: On 3/31/23 12:44, Sam James wrote: Kito Cheng writes: It's not the RISC-V part, so this requires a global maintainer there I think? Someone able to look at the system.h bit? It sh

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-04-02 Thread Andrew Pinski via Gcc-patches
On Sun, Apr 2, 2023 at 12:55 PM Jeff Law via Gcc-patches wrote: > > > > On 3/31/23 12:44, Sam James wrote: > > > > Kito Cheng writes: > > > >> It's not the RISC-V part, so this requires a global maintainer there I > >> think? > >> > > > > Someone able to look at the system.h bit? It should be tr

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-04-02 Thread Jeff Law via Gcc-patches
On 3/31/23 12:44, Sam James wrote: Kito Cheng writes: It's not the RISC-V part, so this requires a global maintainer there I think? Someone able to look at the system.h bit? It should be trivial, there's no uses left and it was added purely for a bug like this in the past (see commit me

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)

2023-03-31 Thread Sam James via Gcc-patches
Kito Cheng writes: > It's not the RISC-V part, so this requires a global maintainer there I think? > Someone able to look at the system.h bit? It should be trivial, there's no uses left and it was added purely for a bug like this in the past (see commit message). > On Tue, Mar 14, 2023 at 8:28

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-03-14 Thread Jeff Law via Gcc-patches
On 3/14/23 07:45, Kito Cheng via Gcc-patches wrote: It's not the RISC-V part, so this requires a global maintainer there I think? It does. I hadn't had a chance to dig into the history of the pthread.h include to understand why it was originally included which would be the first step in det

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-03-14 Thread Kito Cheng via Gcc-patches
It's not the RISC-V part, so this requires a global maintainer there I think? On Tue, Mar 14, 2023 at 8:28 AM juzhe.zh...@rivai.ai wrote: > > Thank you for fixing this. I am not familiar with this. > This generator code (genrvv-type-indexer.cc) is written by @kito. > > Kito ? Can you take a look

Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-03-13 Thread juzhe.zh...@rivai.ai
Thank you for fixing this. I am not familiar with this. This generator code (genrvv-type-indexer.cc) is written by @kito. Kito ? Can you take a look at this? juzhe.zh...@rivai.ai From: Sam James Date: 2023-03-14 08:23 To: gcc-patches CC: Kito Cheng; Palmer Dabbelt; Andrew Waterman; Jim Wilson