Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 2:30 PM Kito Cheng wrote: > > There is an assertion checking to make sure LOCAL_DECL_ALIGNMENT never > shrink alignment, > > But those two testcase did under x86_64 with -m32, I am not sure if > the behavior is expected or not? > It should be fixed on target if that behavio

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
There is an assertion checking to make sure LOCAL_DECL_ALIGNMENT never shrink alignment, But those two testcase did under x86_64 with -m32, I am not sure if the behavior is expected or not? It should be fixed on target if that behavior is not expected. On Wed, May 20, 2020 at 8:06 PM Kito Cheng

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
Ok, I will check. On Wed, May 20, 2020 at 8:04 PM Richard Biener wrote: > > On Wed, May 20, 2020 at 9:20 AM Kito Cheng wrote: > > > > Hi Richard: > > > > Tested and committed with fixes, thanks your review :) > > And we're now hitting > > internal compiler error: in execute, at adjust-alignment.

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 9:20 AM Kito Cheng wrote: > > Hi Richard: > > Tested and committed with fixes, thanks your review :) And we're now hitting internal compiler error: in execute, at adjust-alignment.c:73 for FAIL: gcc.target/i386/pr69454-2.c (internal compiler error) FAIL: gcc.target/i386

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
Hi Richard: Tested and committed with fixes, thanks your review :) On Mon, May 18, 2020 at 6:22 PM Richard Biener wrote: > > On Mon, May 18, 2020 at 9:27 AM Kito Cheng wrote: > > > > ping > > > > On Tue, Apr 14, 2020 at 2:53 PM Kito Cheng wrote: > >> > >> - The alignment for local variable wa

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-18 Thread Richard Biener via Gcc-patches
On Mon, May 18, 2020 at 9:27 AM Kito Cheng wrote: > > ping > > On Tue, Apr 14, 2020 at 2:53 PM Kito Cheng wrote: >> >> - The alignment for local variable was adjust during >> estimate_stack_frame_size, >>however it seems wrong spot to adjust that, expand phase will adjust that >>but it

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-18 Thread Kito Cheng
ping On Tue, Apr 14, 2020 at 2:53 PM Kito Cheng wrote: > - The alignment for local variable was adjust during > estimate_stack_frame_size, >however it seems wrong spot to adjust that, expand phase will adjust > that >but it little too late to some gimple optimization, which rely on > ce