Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Tomasz Kaminski
On Wed, May 21, 2025 at 11:53 AM Luc Grosheintz wrote: > Implements the parts of layout_left that don't depend on any of the > other layouts. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (layout_left): New class. > > Signed-off-by: Luc Grosheintz > --- > libstdc++-v3/include/std

Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Tomasz Kaminski
On Wed, May 21, 2025 at 11:53 AM Luc Grosheintz wrote: > Implements the parts of layout_left that don't depend on any of the > other layouts. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (layout_left): New class. > > Signed-off-by: Luc Grosheintz > --- > libstdc++-v3/include/std

Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Tomasz Kaminski
On Thu, May 22, 2025 at 1:29 PM Luc Grosheintz wrote: > I think part of this didn't get incorporated because I was too hasty > sending v3. The other I just didn't deem useful (I inline the function > for v4). > > There's a default initialization bug I need to fix: _M_exts and > _M_strides must be

Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Tomasz Kaminski
I am still reviewing. Should be able to get throu all of them today. On Thu, May 22, 2025 at 1:29 PM Luc Grosheintz wrote: > I think part of this didn't get incorporated because I was too hasty > sending v3. The other I just didn't deem useful (I inline the function > for v4). > > There's a defa

Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Luc Grosheintz
I think part of this didn't get incorporated because I was too hasty sending v3. The other I just didn't deem useful (I inline the function for v4). There's a default initialization bug I need to fix: _M_exts and _M_strides must be value initialized. Then also the registration in std.cc.in & I'l

Re: [PATCH v3 4/9] libstdc++: Implement layout_left from mdspan.

2025-05-22 Thread Tomasz Kaminski
On Wed, May 21, 2025 at 11:53 AM Luc Grosheintz wrote: > Implements the parts of layout_left that don't depend on any of the > other layouts. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (layout_left): New class. > > Signed-off-by: Luc Grosheintz > --- > libstdc++-v3/include/std