Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-09-04 Thread Marc via Gcc-patches
Richard Sandiford writes: >> +# this regex matches the first line of the "end" in the initial commit >> message >> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by:|co-authored-by:|#) >> ') > > Personally I think it would be safer to drop the final space in the regexp. > > OK with that

Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-09-04 Thread Richard Sandiford via Gcc-patches
Marc Poulhiès via Gcc-patches writes: > Richard Sandiford via Gcc-patches writes: >>> +# this regex matches the first line of the "end" in the initial commit >>> message >>> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by|co-authored-by|#): >>> ') >> >> The current code only requires an