Re: [PATCH v2] rs6000: Remove useless insns fed into lvx/stvx [PR97019]

2020-09-15 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for your suggestions! >> + for (unsigned i = 0; i < and_insns.length (); ++i) > > "i++" is used more often, is more traditional. > Updated. >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr97019.c >> @@ -0,0 +1,82 @@ >> +/* This issue can only exist on littl

Re: [PATCH v2] rs6000: Remove useless insns fed into lvx/stvx [PR97019]

2020-09-15 Thread Segher Boessenkool
Hi Ke Wen, On Tue, Sep 15, 2020 at 02:40:38PM +0800, Kewen.Lin wrote: > >>* config/rs6000/rs6000-p8swap.c (insn_rtx_pair_t): New type. > > > > Please don't do that. The "first" and "second" are completely > > meaningless. Also, keeping it separate arrays can very well result in > > better