Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:20:22PM +0100, Rainer Orth wrote: > Jim Meyering writes: > > >> I honestly don't see the point of this whitespace change unless done > >> across all ChangeLogs, not just a few that you happen to touch. > > > > As I said, it's gone, now, from my patch. > > If no one obje

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> I honestly don't see the point of this whitespace change unless done >> across all ChangeLogs, not just a few that you happen to touch. > > As I said, it's gone, now, from my patch. > If no one objects, I'll normalize all ChangeLog files. No objection per se, although it'

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >>> the change at hand. And please don't change the alignment of entries >>> with multiple email addresses. >> >> Changing 8-spaces to a TAB does not affect alignment when you're >> looking at the ChangeLog file itself with standard tab setting. >> >> Per

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> the change at hand. And please don't change the alignment of entries >> with multiple email addresses. > > Changing 8-spaces to a TAB does not affect alignment when you're > looking at the ChangeLog file itself with standard tab setting. > > Perhaps you looked at a hunk l

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >> I've taken the liberty of letting my editor remove trailing >> blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, >> I converted some leading 8-space (and 7-space) sequences to single TABs. > > Please move this to a separate patch: this

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:28:37AM -0800, Ian Lance Taylor wrote: > Rainer Orth writes: > > >> I found no ChangeLog for libgo and no other libgo-related entries. > >> I suspect that means I should omit this change because it belongs upstream. > > > > Indeed, cf. libgo/README*. I've Cc'ed Ian who

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Ian Lance Taylor
Rainer Orth writes: >> I found no ChangeLog for libgo and no other libgo-related entries. >> I suspect that means I should omit this change because it belongs upstream. > > Indeed, cf. libgo/README*. I've Cc'ed Ian who maintains this part of > GCC. Yes, libgo is upstream but in any case I'd pre

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: > I've taken the liberty of letting my editor remove trailing > blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, > I converted some leading 8-space (and 7-space) sequences to single TABs. Please move this to a separate patch: this is completely unrelated to