Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Uros Bizjak
On Sun, Aug 26, 2012 at 8:11 AM, Uros Bizjak wrote: >> What if we just add a global variable during_combine, and the insn >> predicates can check that variable? Then we wouldn't need a new >> target hook, one that seems slightly obscure to me. > > No, in x86 case we need to look at operand const

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Uros Bizjak
On Sat, Aug 25, 2012 at 9:40 PM, Ian Lance Taylor wrote: v2 patch differences: - moves hook description text to target.def - fixes error path to clear clobbers, as expected by recog_for_combine callers 2012-08-25 Uros Bizjak * target.def (reject_c

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Hans-Peter Nilsson
On Sat, 25 Aug 2012, Uros Bizjak wrote: > On Sat, Aug 25, 2012 at 7:22 PM, Hans-Peter Nilsson wrote: > > Maybe mention that the default is to allow all combinations for > > which a pattern match? And that the reason to disallow them can > > be that they're known to result in suboptimal code? Or

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Georg-Johann Lay
Ian Lance Taylor schrieb: On Sat, Aug 25, 2012 at 11:21 AM, Uros Bizjak wrote: On Sat, Aug 25, 2012 at 7:22 PM, Hans-Peter Nilsson wrote: v2 patch differences: - moves hook description text to target.def - fixes error path to clear clobbers, as expected by recog_for_combine callers 2012-08-

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Ian Lance Taylor
On Sat, Aug 25, 2012 at 11:21 AM, Uros Bizjak wrote: > On Sat, Aug 25, 2012 at 7:22 PM, Hans-Peter Nilsson wrote: > >>> v2 patch differences: >>> - moves hook description text to target.def >>> - fixes error path to clear clobbers, as expected by recog_for_combine >>> callers >>> >>> 2012-08-25

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Georg-Johann Lay
Oleg Endo schrieb: On Sat, 2012-08-25 at 20:25 +0200, Georg-Johann Lay wrote: BTW: while I typed the lines above I find it more natural to return "true" for good patterns and "false" for bad patterns and not vice versa. But that's just a matter of taste. But then that won't fit with 'reject_

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Oleg Endo
On Sat, 2012-08-25 at 20:25 +0200, Georg-Johann Lay wrote: > BTW: while I typed the lines above I find it more natural to > return "true" for good patterns and "false" for bad patterns > and not vice versa. But that's just a matter of taste. But then that won't fit with 'reject_combined_insn'. R

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Georg-Johann Lay
Uros Bizjak schrieb: On Sat, Aug 25, 2012 at 6:54 PM, Georg-Johann Lay wrote: Hello! v2 patch differences: - moves hook description text to target.def - fixes error path to clear clobbers, as expected by recog_for_combine callers 2012-08-25 Uros Bizjak * target.def (reject_combin

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Uros Bizjak
On Sat, Aug 25, 2012 at 7:22 PM, Hans-Peter Nilsson wrote: >> v2 patch differences: >> - moves hook description text to target.def >> - fixes error path to clear clobbers, as expected by recog_for_combine >> callers >> >> 2012-08-25 Uros Bizjak >> >> * target.def (reject_combined_insn):

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Uros Bizjak
On Sat, Aug 25, 2012 at 6:54 PM, Georg-Johann Lay wrote: >> Hello! >> >> v2 patch differences: >> - moves hook description text to target.def >> - fixes error path to clear clobbers, as expected by recog_for_combine >> callers >> >> 2012-08-25 Uros Bizjak >> >> * target.def (reject_com

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Hans-Peter Nilsson
On Sat, 25 Aug 2012, Uros Bizjak wrote: > Hello! > > v2 patch differences: > - moves hook description text to target.def > - fixes error path to clear clobbers, as expected by recog_for_combine callers > > 2012-08-25 Uros Bizjak > > * target.def (reject_combined_insn): New target hook. >

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Georg-Johann Lay
Uros Bizjak schrieb: Hello! v2 patch differences: - moves hook description text to target.def - fixes error path to clear clobbers, as expected by recog_for_combine callers 2012-08-25 Uros Bizjak * target.def (reject_combined_insn): New target hook. * doc/tm.texi.in (TARGET_