Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

On 6/6/24 09:23, Evgeny Karpov wrote: Thursday, June 6, 2024 1:42 AM Jonathan Yong <10wa...@gmail.com> wrote: Where is HAVE_64BIT_POINTERS used? Sorry, it was missed in the posted changes for review. Regards, Evgeny diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h index

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

Thursday, June 6, 2024 1:42 AM Jonathan Yong <10wa...@gmail.com> wrote: > > Where is HAVE_64BIT_POINTERS used? > Sorry, it was missed in the posted changes for review. Regards, Evgeny diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h index 8a6f0e8e8a5..0c9d5424942 100644 ---

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

On 6/5/24 06:01, Uros Bizjak wrote: On Tue, Jun 4, 2024 at 10:10 PM Evgeny Karpov wrote: Richard and Uros, could you please review the changes for v2? LGTM for the generic x86 part, OS-specific part (cygming) should also be reviewed by OS port maintainer (CC'd). Thanks, Uros. Where is HA

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

Evgeny Karpov writes: > Richard and Uros, could you please review the changes for v2? > Additionally, we have detected an issue with GCC GC in winnt-dll.cc. The fix > will be included in v2. Would it be possible to have a more "purposeful" name than CMODEL_IS_NOT_LARGE_OR_MEDIUM_PIC? What's the

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

On Tue, Jun 4, 2024 at 10:10 PM Evgeny Karpov wrote: > > Richard and Uros, could you please review the changes for v2? LGTM for the generic x86 part, OS-specific part (cygming) should also be reviewed by OS port maintainer (CC'd). Thanks, Uros. > Additionally, we have detected an issue with GCC