Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-07-01 Thread Jason Merrill
On 7/1/25 10:57 AM, Florian Weimer wrote: * Jason Merrill: On 6/30/25 5:22 PM, Florian Weimer wrote: * Jason Merrill: On 6/28/25 3:17 PM, Florian Weimer wrote: * Jason Merrill: Since r10-6069[1] we control the call to __cxa_finalize with DEFAULT_USE_CXA_ATEXIT, so there's no need to also

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-07-01 Thread Florian Weimer
* Jason Merrill: > On 6/30/25 5:22 PM, Florian Weimer wrote: >> * Jason Merrill: >> >>> On 6/28/25 3:17 PM, Florian Weimer wrote: * Jason Merrill: > Since r10-6069[1] we control the call to __cxa_finalize with > DEFAULT_USE_CXA_ATEXIT, so there's no need to also declare it as a

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-07-01 Thread Jason Merrill
On 6/30/25 5:22 PM, Florian Weimer wrote: * Jason Merrill: On 6/28/25 3:17 PM, Florian Weimer wrote: * Jason Merrill: Since r10-6069[1] we control the call to __cxa_finalize with DEFAULT_USE_CXA_ATEXIT, so there's no need to also declare it as a weak reference; if the target has __cxa_atexit

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-06-30 Thread Florian Weimer
* Jason Merrill: > On 6/28/25 3:17 PM, Florian Weimer wrote: >> * Jason Merrill: >> >>> Since r10-6069[1] we control the call to __cxa_finalize with >>> DEFAULT_USE_CXA_ATEXIT, so there's no need to also declare it as a weak >>> reference; if the target has __cxa_atexit, it must also have __cxa_f

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-06-30 Thread Joseph Myers
On Sat, 28 Jun 2025, Jason Merrill wrote: > + if (!flag_use_cxa_atexit != !DEFAULT_USE_CXA_ATEXIT) > +{ > + const char *opt, *copt; > + if (flag_use_cxa_atexit) > + opt = "-fuse-cxa-atexit", copt = "--enable-__cxa_atexit"; > + else > + opt = "-fno-use-cxa-atexit", copt

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-06-29 Thread Jason Merrill
On 6/28/25 3:17 PM, Florian Weimer wrote: * Jason Merrill: Since r10-6069[1] we control the call to __cxa_finalize with DEFAULT_USE_CXA_ATEXIT, so there's no need to also declare it as a weak reference; if the target has __cxa_atexit, it must also have __cxa_finalize. I expect that most targe

Re: [PATCH RFC] libgcc: don't use a weak ref for __cxa_finalize

2025-06-28 Thread Florian Weimer
* Jason Merrill: > Since r10-6069[1] we control the call to __cxa_finalize with > DEFAULT_USE_CXA_ATEXIT, so there's no need to also declare it as a weak > reference; if the target has __cxa_atexit, it must also have __cxa_finalize. I expect that most targets do not need __cxa_finalize. They can