Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.

2019-08-08 Thread Robin Dapp
Hi Richard, > Is the separate need_temps scan required for correctness? It looked > like we could test: > > if (reg_overlap_mentioned_p (dest, cond)) > ... > > on-the-fly during the main noce_convert_multiple_sets loop. right, I didn't re-check it but after changes during interal p

Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.

2019-08-06 Thread Richard Sandiford
Robin Dapp writes: > noce_convert_multiple_sets creates temporaries for the destination of > every emitted cmov and expects subsequent passes to get rid of them. This > does not happen every time and even if the temporaries are removed, code > generation can be affected adversely. In this patch,