Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Pedro Alves
On 04/28/2017 08:01 PM, Pedro Alves wrote: > On 04/28/2017 05:28 PM, Martin Sebor wrote: >> On 04/28/2017 05:47 AM, Nathan Sidwell wrote: > @@ -427,9 +429,31 @@ static void output_lines (FILE *, const source_t *); static char *make_gcov_file_name (const char *, const char *);

Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Martin Sebor
On 04/28/2017 01:01 PM, Pedro Alves wrote: On 04/28/2017 05:28 PM, Martin Sebor wrote: On 04/28/2017 05:47 AM, Nathan Sidwell wrote: @@ -427,9 +429,31 @@ static void output_lines (FILE *, const source_t *); static char *make_gcov_file_name (const char *, const char *); static char *mangle

Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Pedro Alves
On 04/28/2017 05:28 PM, Martin Sebor wrote: > On 04/28/2017 05:47 AM, Nathan Sidwell wrote: >>> @@ -427,9 +429,31 @@ static void output_lines (FILE *, const source_t >>> *); >>> static char *make_gcov_file_name (const char *, const char *); >>> static char *mangle_name (const char *, char *);

Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Nathan Sidwell
On 04/28/2017 12:28 PM, Martin Sebor wrote: Unless it's some other kind of vector, the patch adds a vector member to the class, which makes it not a PoD.(*) oh, well double ew. Your code is bad and you should feel bad. Write proper member initializers please. [*] Strictly speaking using m

Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Martin Sebor
On 04/28/2017 05:47 AM, Nathan Sidwell wrote: On 04/21/2017 10:02 AM, marxin wrote: gcc/ChangeLog: 2017-04-26 Martin Liska * gcov.c (struct block_location_info): New struct. (process_file): Fill up the new structure. (read_graph_file): Replace usage of encoding by the newly adde

Re: [PATCH 3/8] Simplify representation of locations of a block.

2017-04-28 Thread Nathan Sidwell
On 04/21/2017 10:02 AM, marxin wrote: gcc/ChangeLog: 2017-04-26 Martin Liska * gcov.c (struct block_location_info): New struct. (process_file): Fill up the new structure. (read_graph_file): Replace usage of encoding by the newly added struct. (add_line