Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-16 Thread Martin Liška
On 9/16/19 5:04 AM, Richard Biener wrote: On Wed, 11 Sep 2019, Martin Liška wrote: On 9/11/19 3:19 PM, Martin Liška wrote: On 9/11/19 2:43 PM, Richard Biener wrote: Any particular reason you needed to swap the calls in maybe_fold_and/or_comparisons? You didn't answer this, besides that the

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-16 Thread Richard Biener
On Wed, 11 Sep 2019, Martin Liška wrote: > On 9/11/19 3:19 PM, Martin Liška wrote: > > On 9/11/19 2:43 PM, Richard Biener wrote: > >> Any particular reason you needed to swap the calls in > >> maybe_fold_and/or_comparisons? You didn't answer this, besides that the patch is OK. Thanks, Richard.

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Martin Liška
On 9/11/19 3:19 PM, Martin Liška wrote: > On 9/11/19 2:43 PM, Richard Biener wrote: >> On Wed, 11 Sep 2019, Martin Liška wrote: >> >>> I'm sending updated version of the patch where I changed >>> from previous version: >>> - more compact matching is used (note @3 and @4): >>> (and (code1:c@3 @0 I

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Martin Liška
On 9/11/19 2:43 PM, Richard Biener wrote: > On Wed, 11 Sep 2019, Martin Liška wrote: > >> I'm sending updated version of the patch where I changed >> from previous version: >> - more compact matching is used (note @3 and @4): >> (and (code1:c@3 @0 INTEGER_CST@1) (code2:c@4 @0 INTEGER_CST@2)) >>

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Richard Biener
On Wed, 11 Sep 2019, Martin Liška wrote: > I'm sending updated version of the patch where I changed > from previous version: > - more compact matching is used (note @3 and @4): > (and (code1:c@3 @0 INTEGER_CST@1) (code2:c@4 @0 INTEGER_CST@2)) > > Patch can bootstrap on x86_64-linux-gnu and surv

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Martin Liška
I'm sending updated version of the patch where I changed from previous version: - more compact matching is used (note @3 and @4): (and (code1:c@3 @0 INTEGER_CST@1) (code2:c@4 @0 INTEGER_CST@2)) Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks,

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Martin Liška
On 9/10/19 1:19 PM, Marc Glisse wrote: > (some quick comments, I didn't check in details) Thanks for them. > > +    (and:c (code1 @0 INTEGER_CST@1) (code2 @0 INTEGER_CST@2)) > [...] > +   (if (code1 == NE_EXPR && !val) (code2 @0 @2 > > How about > > (and:c (code1 @0 INTEGER_CST@1)

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-11 Thread Martin Liška
On 9/10/19 10:52 AM, Bernhard Reutner-Fischer wrote: > On 9 September 2019 15:41:05 CEST, "Martin Liška" wrote: >> On 9/9/19 2:24 PM, Martin Liška wrote: >>> Hi. >>> >>> The patch is about transition of and_comparisons_1 matching >>> into match.pd. >>> >>> Patch can bootstrap on x86_64-linux-gnu a

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-10 Thread Marc Glisse
(some quick comments, I didn't check in details) +(and:c (code1 @0 INTEGER_CST@1) (code2 @0 INTEGER_CST@2)) [...] + (if (code1 == NE_EXPR && !val) (code2 @0 @2 How about (and:c (code1 @0 INTEGER_CST@1) (code2@3 @0 INTEGER_CST@2)) [...] (if (code1 == NE_EXPR && !val) @3)))

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-10 Thread Bernhard Reutner-Fischer
On 9 September 2019 15:41:05 CEST, "Martin Liška" wrote: >On 9/9/19 2:24 PM, Martin Liška wrote: >> Hi. >> >> The patch is about transition of and_comparisons_1 matching >> into match.pd. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression >tests. >> >> Ready to be installed?

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-10 Thread Martin Liška
On 9/9/19 3:41 PM, Martin Liška wrote: On 9/9/19 2:24 PM, Martin Liška wrote: Hi. The patch is about transition of and_comparisons_1 matching into match.pd. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin Updated version (as ment

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

2019-09-09 Thread Martin Liška
On 9/9/19 2:24 PM, Martin Liška wrote: > Hi. > > The patch is about transition of and_comparisons_1 matching > into match.pd. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > Updated version (as mentioned in part 1). Ma