Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Hi Tamar, On Fri, Oct 29, 2021 at 5:23 PM Richard Sandiford via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > Tamar Christina writes: > > Hi All, > > > > Attached is a new version that fixes the previous SVE fallouts in a new > way. > > > > Ok for master? > Looks like you forgot to try to b

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina writes: > Hi All, > > Attached is a new version that fixes the previous SVE fallouts in a new way. > > Ok for master? > > Thanks, > Tamar > > --- inline copy of patch --- > > > diff --git a/gcc/config/aarch64/aarch64-cost-tables.h > b/gcc/config/aarch64/aarch64-cost-tables.h > ind

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Hi All, Attached is a new version that fixes the previous SVE fallouts in a new way. Ok for master? Thanks, Tamar --- inline copy of patch --- diff --git a/gcc/config/aarch64/aarch64-cost-tables.h b/gcc/config/aarch64/aarch64-cost-tables.h index dd2e7e7cbb13d24f0b51092270cd7e2d75fabf29..bb4

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

> -Original Message- > From: Richard Sandiford > Sent: Tuesday, October 26, 2021 3:46 PM > To: Tamar Christina > Cc: Tamar Christina via Gcc-patches ; Richard > Earnshaw ; nd ; Marcus > Shawcroft > Subject: Re: [PATCH 2/2]AArch64: Add better costing fo

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina writes: > Hi, > > Following the discussion below here's a revised patch. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for master? Looks good functionally, just got some comments about the implementation. > @@ -14006,8 +14007,52 @@ cost_plus: >

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

)prodH); +return vget_lane_u16((uint16x4_t)res, 3); +} + > -----Original Message----- > From: Richard Sandiford > Sent: Monday, October 25, 2021 3:32 PM > To: Tamar Christina > Cc: Tamar Christina via Gcc-patches ; Richard > Earnshaw ; nd ; Marcus > Shawcroft > Subject

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

t; To: Tamar Christina via Gcc-patches >> >> Cc: Tamar Christina ; Richard Earnshaw >> >> ; nd ; Marcus Shawcroft >> >> >> >> Subject: Re: [PATCH 2/2]AArch64: Add better costing for vector >> >> constants and operations >> >> >

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

> -Original Message- > From: Richard Sandiford > Sent: Monday, October 25, 2021 10:54 AM > To: Tamar Christina > Cc: Tamar Christina via Gcc-patches ; Richard > Earnshaw ; nd ; Marcus > Shawcroft > Subject: Re: [PATCH 2/2]AArch64: Add better costing fo

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Saturday, October 23, 2021 11:40 AM >> To: Tamar Christina via Gcc-patches >> Cc: Tamar Christina ; Richard Earnshaw >> ; nd ; Marcus Shawcroft >> >> Sub

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

> -Original Message- > From: Richard Sandiford > Sent: Saturday, October 23, 2021 11:40 AM > To: Tamar Christina via Gcc-patches > Cc: Tamar Christina ; Richard Earnshaw > ; nd ; Marcus Shawcroft > > Subject: Re: [PATCH 2/2]AArch64: Add better costing fo

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina via Gcc-patches writes: >> I'm still a bit sceptical about treating the high-part cost as lower. >> ISTM that the subreg cases are the ones that are truly “free” and any others >> should have a normal cost. So if CSE handled the subreg case itself (to >> model >> how the rtx woul

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

- > >> >> From: Richard Sandiford > >> >> Sent: Tuesday, August 31, 2021 4:14 PM > >> >> To: Tamar Christina > >> >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > >> >> ; Marcus Shawc

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

t; >> To: Tamar Christina >> >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw >> >> ; Marcus Shawcroft >> >> ; Kyrylo Tkachov >> >> >> Subject: Re: [PATCH 2/2]AArch64: Add better costing for vector >> >> constants and op

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

> -Original Message- > From: Richard Sandiford > Sent: Tuesday, August 31, 2021 5:07 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH 2/2]AArch64: Add better costing fo

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Tuesday, August 31, 2021 4:14 PM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw >> ; Marcus Shawcroft >> ; Kyrylo Tkachov >

RE: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

> -Original Message- > From: Richard Sandiford > Sent: Tuesday, August 31, 2021 4:14 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH 2/2]AArch64: Add better costing fo

Re: [PATCH 2/2]AArch64: Add better costing for vector constants and operations

Tamar Christina writes: > @@ -13936,8 +13937,65 @@ cost_plus: >mode, MULT, 1, speed); >return true; > } > + break; > +case PARALLEL: > + /* Fall through */ Which code paths lead to getting a PARALLEL here? > +case CONST_VECTOR: >