Re: [PATCH 11/18] add some utility methods to vec

2016-04-20 Thread Trevor Saunders
On Wed, Apr 20, 2016 at 11:13:42AM +0200, Richard Biener wrote: > On Wed, Apr 20, 2016 at 8:22 AM, wrote: > > From: Trevor Saunders > > > > Later patches use these functions, and I believe Mikhail has mentioned > > before > > he'd like to have begin / end () on vec before. > > begin() / end ()

Re: [PATCH 11/18] add some utility methods to vec

2016-04-20 Thread Segher Boessenkool
On Wed, Apr 20, 2016 at 02:22:15AM -0400, tbsaunde+...@tbsaunde.org wrote: > +template > +inline bool > +vec_safe_contains (vec *v, const T &search) > +{ > + return v? v->contains (search) : false; > +} Missing space. Segher

Re: [PATCH 11/18] add some utility methods to vec

2016-04-20 Thread Richard Biener
On Wed, Apr 20, 2016 at 8:22 AM, wrote: > From: Trevor Saunders > > Later patches use these functions, and I believe Mikhail has mentioned before > he'd like to have begin / end () on vec before. begin() / end () is fine. But contains ()? That makes using a O(n) algorithm too easy I think (we