Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-14 Thread Patrick Palka
On Thu, 14 Jan 2016, Jeff Law wrote: On 01/10/2016 08:55 PM, Patrick Palka wrote: On Mon, Jan 4, 2016 at 1:35 PM, Jeff Law wrote: On 01/02/2016 04:26 PM, Patrick Palka wrote: On Sat, Jan 2, 2016 at 3:21 AM, Jakub Jelinek wrote: On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote:

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-14 Thread Jeff Law
On 01/10/2016 08:55 PM, Patrick Palka wrote: On Mon, Jan 4, 2016 at 1:35 PM, Jeff Law wrote: On 01/02/2016 04:26 PM, Patrick Palka wrote: On Sat, Jan 2, 2016 at 3:21 AM, Jakub Jelinek wrote: On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote: gcc/cp/ChangeLog: * cp-array-not

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-10 Thread Patrick Palka
On Mon, Jan 4, 2016 at 1:35 PM, Jeff Law wrote: > On 01/02/2016 04:26 PM, Patrick Palka wrote: >> >> On Sat, Jan 2, 2016 at 3:21 AM, Jakub Jelinek wrote: >>> >>> On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote: > > gcc/cp/ChangeLog: > > * cp-array-notation.c (cp_expa

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-04 Thread Jeff Law
On 01/02/2016 04:26 PM, Patrick Palka wrote: On Sat, Jan 2, 2016 at 3:21 AM, Jakub Jelinek wrote: On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote: gcc/cp/ChangeLog: * cp-array-notation.c (cp_expand_cond_array_notations): Return error_mark_node only if find_rank failed, not

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-02 Thread Patrick Palka
On Sat, Jan 2, 2016 at 3:21 AM, Jakub Jelinek wrote: > On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote: >> >gcc/cp/ChangeLog: >> > >> > * cp-array-notation.c (cp_expand_cond_array_notations): Return >> > error_mark_node only if find_rank failed, not if it was >> > successful.

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-02 Thread Jakub Jelinek
On Fri, Jan 01, 2016 at 10:06:34PM -0700, Jeff Law wrote: > >gcc/cp/ChangeLog: > > > > * cp-array-notation.c (cp_expand_cond_array_notations): Return > > error_mark_node only if find_rank failed, not if it was > > successful. > Can you use -fdump-tree-original in the testcase and verify

Re: [PATCH 1/3] Fix logic bug in Cilk Plus array expansion

2016-01-01 Thread Jeff Law
On 12/31/2015 08:40 AM, Patrick Palka wrote: The Cilk Plus code may sometimes turn a COND_EXPR into an error_mark_node for no good reason. This can be seen by compiling the test case c-c++-common/cilk-plus/CK/pr60469.c with both gcc and g++ and observing the differences of the -fdump-tree-origin