Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Richard Biener via Gcc-patches
On Wed, Aug 10, 2022 at 1:11 PM Martin Liška wrote: > > On 8/10/22 12:47, Richard Biener wrote: > > Yeah, fair enough. > > I'm going to install the v3 where I renamed jobserver.h > and moved the ctor implementation to opts-common.cc. For the record, the v3 series is OK > Cheers, > Martin

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Martin Liška
On 8/10/22 12:47, Richard Biener wrote: > Yeah, fair enough. I'm going to install the v3 where I renamed jobserver.h and moved the ctor implementation to opts-common.cc. Cheers, MartinFrom 6f3abcb3fa26f6ed719450f6bc70b2b37179973a Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 9 Aug 2022

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Richard Biener via Gcc-patches
On Wed, Aug 10, 2022 at 11:30 AM Martin Liška wrote: > > On 8/10/22 09:47, Richard Biener wrote: > > On Wed, Aug 10, 2022 at 9:17 AM Martin Liška wrote: > >> > >> On 8/10/22 08:56, Richard Biener wrote: > >>> C++ standard library includes have to go through system.h (#define > >>> INCLUDE_STRING)

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Martin Liška
On 8/10/22 09:47, Richard Biener wrote: > On Wed, Aug 10, 2022 at 9:17 AM Martin Liška wrote: >> >> On 8/10/22 08:56, Richard Biener wrote: >>> C++ standard library includes have to go through system.h (#define >>> INCLUDE_STRING). >> >> Oh, yeah. That means I need to rely on the flat header files

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Richard Biener via Gcc-patches
On Wed, Aug 10, 2022 at 9:17 AM Martin Liška wrote: > > On 8/10/22 08:56, Richard Biener wrote: > > C++ standard library includes have to go through system.h (#define > > INCLUDE_STRING). > > Oh, yeah. That means I need to rely on the flat header files :/ > > > > > Does the API really have to use

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-10 Thread Martin Liška
On 8/10/22 08:56, Richard Biener wrote: > C++ standard library includes have to go through system.h (#define > INCLUDE_STRING). Oh, yeah. That means I need to rely on the flat header files :/ > > Does the API really have to use std::string? I would like to. My main motivation is std::string::rf

Re: [PATCH 1/3] Factor out jobserver_active_p.

2022-08-09 Thread Richard Biener via Gcc-patches
On Tue, Aug 9, 2022 at 2:03 PM Martin Liška wrote: > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > * gcc.cc (driver::detect_jobserver): Remove and move to > jobserver.h. > * lto-