Re: [PATCH 08/25] Fix co-array allocation

2018-09-23 Thread Janne Blomqvist
On Fri, Sep 21, 2018 at 10:33 AM Toon Moene wrote: > On 09/20/2018 10:01 PM, Thomas Koenig wrote: > > > Hi Damian, > > > >> On a related note, two Sourcery Institute developers have attempted to > >> edit > >> the GCC build system to make the downloading and building of > OpenCoarrays > >> automa

Re: [PATCH 08/25] Fix co-array allocation

2018-09-21 Thread Toon Moene
On 09/20/2018 10:01 PM, Thomas Koenig wrote: Hi Damian, On a related note, two Sourcery Institute developers have attempted to edit the GCC build system to make the downloading and building of OpenCoarrays automatically part of the gfortran build process.  Neither developer succeeded. We ad

Re: [PATCH 08/25] Fix co-array allocation

2018-09-20 Thread Damian Rouson
On Thu, Sep 20, 2018 at 1:01 PM Thomas Koenig wrote: > > We addressed integrating OpenCoarray into the gcc source tree at the > recent Gcc summit during the gfortran BoF session. > I agree with keeping it as a separate code base, but comments from some gfortran developers on the gfortran mailing

Re: [PATCH 08/25] Fix co-array allocation

2018-09-20 Thread Thomas Koenig
Hi Damian, On a related note, two Sourcery Institute developers have attempted to edit the GCC build system to make the downloading and building of OpenCoarrays automatically part of the gfortran build process. Neither developer succeeded. We addressed integrating OpenCoarray into the gcc sou

Re: [PATCH 08/25] Fix co-array allocation

2018-09-20 Thread Andrew Stubbs
On 20/09/18 16:56, Janne Blomqvist wrote: Ok, looks good. Thanks. There are some other remaining incorrect uses of integer_type_node (at least one visible in the diff), but that can be done as a separate patch (not saying you must do it as a precondition for anything, though it would of cou

Re: [PATCH 08/25] Fix co-array allocation

2018-09-20 Thread Janne Blomqvist
On Wed, Sep 19, 2018 at 7:24 PM Andrew Stubbs wrote: > On 05/09/18 19:07, Janne Blomqvist wrote: > > The argument must be of type size_type_node, not sizetype. Please instead > > use > > > > size = build_zero_cst (size_type_node); > > > > > >> * trans-intrinsic.c (conv_intrinsic_event_qu

Re: [PATCH 08/25] Fix co-array allocation

2018-09-19 Thread Damian Rouson
On Wed, Sep 19, 2018 at 3:30 PM Andrew Stubbs wrote: > > If you want to port your tool to GCN that would be cool, but I suspect > non-trivial. > To clarify, OpenCoarrays is not a tool. It is the parallel ABI required to create executable programs capable of executing in multiple images as requi

Re: [PATCH 08/25] Fix co-array allocation

2018-09-19 Thread Andrew Stubbs
On 19/09/18 22:18, Damian Rouson wrote: Has this been tested in multi-image execution using OpenCoarrays?   If not, I would be glad to assist with installing OpenCoarrays so that it can be part of the testing process. It's been tested with the GCC testsuite -- the same suite that found the is

Re: [PATCH 08/25] Fix co-array allocation

2018-09-19 Thread Damian Rouson
Has this been tested in multi-image execution using OpenCoarrays? If not, I would be glad to assist with installing OpenCoarrays so that it can be part of the testing process. On a related note, two Sourcery Institute developers have attempted to edit the GCC build system to make the downloading

Re: [PATCH 08/25] Fix co-array allocation

2018-09-19 Thread Andrew Stubbs
On 05/09/18 19:07, Janne Blomqvist wrote: The argument must be of type size_type_node, not sizetype. Please instead use size = build_zero_cst (size_type_node); * trans-intrinsic.c (conv_intrinsic_event_query): Convert computed index to a size_t type. Using integer_type_no

Re: [PATCH 08/25] Fix co-array allocation

2018-09-05 Thread Janne Blomqvist
Please send fortran patches to the fortran list as well! On Wed, Sep 5, 2018 at 7:54 PM Toon Moene wrote: > > > > Forwarded Message > Subject: [PATCH 08/25] Fix co-array allocation > Date: Wed, 5 Sep 2018 12:49:40 +0100 > From: a...@codesourcery.com > To: gcc-patches@gcc.gnu.or