Re: [PATCH] s390: Add expander for uaddc/usubc optabs

2024-11-21 Thread Stefan Schulze Frielinghaus
On Mon, Nov 18, 2024 at 09:32:29AM +0100, Andreas Krebbel wrote: > Hi Stefan, > > > On 11/12/24 10:35, Stefan Schulze Frielinghaus wrote: > > > > + rtx cond = gen_rtx_LTU (mode, gen_rtx_REG (CCL1mode, > > > > CC_REGNUM), const0_rtx); > > > > + if (operands[4] == const0_rtx) > > > > +emit_i

Re: [PATCH] s390: Add expander for uaddc/usubc optabs

2024-11-18 Thread Andreas Krebbel
Hi Stefan, On 11/12/24 10:35, Stefan Schulze Frielinghaus wrote: + rtx cond = gen_rtx_LTU (mode, gen_rtx_REG (CCL1mode, CC_REGNUM), const0_rtx); + if (operands[4] == const0_rtx) +emit_insn (gen_add3_carry1_cc (operands[0], operands[2], operands[3])); + else If we would just generate t

Re: [PATCH] s390: Add expander for uaddc/usubc optabs

2024-11-12 Thread Stefan Schulze Frielinghaus
On Mon, Nov 11, 2024 at 11:29:16AM +0100, Andreas Krebbel wrote: > Hi Stefan, > > thanks for the patch and sorry for the slow review. No worries. Thanks for the detailed review. Much appreciated! > > > On 9/18/24 19:25, Stefan Schulze Frielinghaus wrote: > > Bootstrapped and regtested on s390

Re: [PATCH] s390: Add expander for uaddc/usubc optabs

2024-11-11 Thread Andreas Krebbel
Hi Stefan, thanks for the patch and sorry for the slow review. On 9/18/24 19:25, Stefan Schulze Frielinghaus wrote: Bootstrapped and regtested on s390. Both expander are constrained to z196 because of the conditional moves. I guess this is reasonable nowadays. The reason for the limitation