Re: [PATCH] recog.c: Fix RTX unsharing in change groups - v2

2011-03-22 Thread Eric Botcazou
> 2011-03-22 Andreas Krebbel > > * recog.c (canonicalize_change_group): Use validate_unshare_change. OK, thanks. -- Eric Botcazou

Re: [PATCH] recog.c: Fix RTX unsharing in change groups

2011-03-21 Thread Eric Botcazou
> I think with the patch validate_(unshare)_change becomes easier to use. You > can still decide locally if you want unsharing or not. Without taking into > account in which contexts your function gets called. I consider this a big > advantage. You're supposed to know what you're doing though and

Re: [PATCH] recog.c: Fix RTX unsharing in change groups

2011-03-21 Thread Andreas Krebbel
On 03/18/2011 09:11 PM, Eric Botcazou wrote: >> The attached patch prevents that by doing RTX unsharing for all >> subsequent changes after finding a single change where unsharing has >> been explicitly requested. > > This looks like a big hammer. Why not doing it in canonicalize_change_group, >

Re: [PATCH] recog.c: Fix RTX unsharing in change groups

2011-03-18 Thread Eric Botcazou
> The attached patch prevents that by doing RTX unsharing for all > subsequent changes after finding a single change where unsharing has > been explicitly requested. This looks like a big hammer. Why not doing it in canonicalize_change_group, i.e. calling validate_unshare_change instead of valid