Re: [PATCH] line-map include-from representation

2018-08-08 Thread Nathan Sidwell
On 08/08/2018 11:36 AM, David Malcolm wrote: In r255786 I adjusted prune.exp to move the dg-regexp handling to before the pruning. Unfortunately, handle-multiline-outputs is still after the pruning. I guess we could try moving that to before as well, but I suspect it might break some things.

Re: [PATCH] line-map include-from representation

2018-08-08 Thread David Malcolm
On Wed, 2018-08-08 at 11:36 -0400, David Malcolm wrote: > On Wed, 2018-08-08 at 11:28 -0400, Nathan Sidwell wrote: > > On 08/08/2018 10:46 AM, David Malcolm wrote: > > > > > [...snip...] > > > > > > We don't seem to have much test coverage for this code. Sorry to > > > be a > > > pain, but could

Re: [PATCH] line-map include-from representation

2018-08-08 Thread David Malcolm
On Wed, 2018-08-08 at 11:28 -0400, Nathan Sidwell wrote: > On 08/08/2018 10:46 AM, David Malcolm wrote: > > > [...snip...] > > > > We don't seem to have much test coverage for this code. Sorry to > > be a > > pain, but could you please try adding a testcase of a diagnostic > > issued > > from wi

Re: [PATCH] line-map include-from representation

2018-08-08 Thread Nathan Sidwell
On 08/08/2018 10:46 AM, David Malcolm wrote: [...snip...] We don't seem to have much test coverage for this code. Sorry to be a pain, but could you please try adding a testcase of a diagnostic issued from within a couple of levels of nested includes, perhaps using /* { dg-options "-fdiagnosti

Re: [PATCH] line-map include-from representation

2018-08-08 Thread David Malcolm
On Wed, 2018-08-08 at 09:06 -0400, Nathan Sidwell wrote: > This patch changes the way line-maps hold the included-from > information. > Currently this is an index to another (earlier) line-map, and > relies > on the fact that #include cause the termination of the current map > and > emission o