Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: In the title, we usually put link to bugzilla *PR119741* in your case, not the paper. Then link the paper in commit descritpion. Add constructors to stringbuf, stringstream, istringstream, >

Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Tue, 20 May 2025 at 09:10, Tomasz Kaminski wrote: > > > > On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: > In the title, we usually put link to bugzilla PR119741 in your case, not the > paper. > Then link the paper in commit descritpion. > >> Add constructors to stringbuf, stringstream,

Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Tue, 20 May 2025 at 10:08, Jonathan Wakely wrote: > > On Tue, 20 May 2025 at 09:10, Tomasz Kaminski wrote: > > > > > > > > On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: > > In the title, we usually put link to bugzilla PR119741 in your case, not > > the paper. > > Then link the paper

Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Tue, May 20, 2025 at 11:26 AM Jonathan Wakely wrote: > On Tue, 20 May 2025 at 10:08, Jonathan Wakely > wrote: > > > > On Tue, 20 May 2025 at 09:10, Tomasz Kaminski > wrote: > > > > > > > > > > > > On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: > > > In the title, we usually put link t

Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Tue, 20 May 2025 at 09:10, Tomasz Kaminski wrote: > > > > On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: > In the title, we usually put link to bugzilla PR119741 in your case, not the > paper. > Then link the paper in commit descritpion. Right. When there's no bugzilla I'll sometimes p

Re: [PATCH] libstdc++: Implement stringstream from string_view [P2495R3]

On Tue, 20 May 2025 at 09:10, Tomasz Kaminski wrote: > > > > On Mon, May 19, 2025 at 11:28 PM Nathan Myers wrote: >> +void >> +test02() >> +{ >> + // Test C++26 constructors taking string views using different allocators >> + >> + using alloc_type = __gnu_test::tracker_allocator; > > I would us