Re: [PATCH] libstdc++: Fix constexpr memory algo tests for COW std::string

2025-03-11 Thread Jonathan Wakely
On Thu, 6 Mar 2025 at 11:47, Jonathan Wakely wrote: > > On Thu, 6 Mar 2025 at 11:36, Giuseppe D'Angelo > wrote: > > > > Hi, > > > > On 06/03/2025 12:26, Jonathan Wakely wrote: > > > The old COW std::string is not usable in constant expressions, so these > > > new tests fail with -D_GLIBCXX_USE_CX

Re: [PATCH] libstdc++: Fix constexpr memory algo tests for COW std::string

2025-03-06 Thread Jonathan Wakely
On Thu, 6 Mar 2025 at 11:36, Giuseppe D'Angelo wrote: > > Hi, > > On 06/03/2025 12:26, Jonathan Wakely wrote: > > The old COW std::string is not usable in constant expressions, so these > > new tests fail with -D_GLIBCXX_USE_CXX11_ABI=0. > > LGTM; is there a specific incantation to run the testsui

Re: [PATCH] libstdc++: Fix constexpr memory algo tests for COW std::string

2025-03-06 Thread Giuseppe D'Angelo
Hi, On 06/03/2025 12:26, Jonathan Wakely wrote: The old COW std::string is not usable in constant expressions, so these new tests fail with -D_GLIBCXX_USE_CXX11_ABI=0. LGTM; is there a specific incantation to run the testsuite with both libstdc++ ABIs? Clearly I just tested the new one... T