Re: [PATCH] libgccjit: Fix float vector comparison

2023-01-12 Thread Antoni Boucher via Gcc-patches
Ping David: Some more notes about the try/catch API: I finally got unwinding implemented in rustc_codegen_gcc with the following GCC patch: https://github.com/antoyo/gcc/commit/fd603a3c715d3708f831cb637fbcc48bf4641859 It still requires clean-up, but you can have a look at it. I'm still unsure for

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-02 Thread Antoni Boucher via Gcc-patches
I'm posting the patch again so that you can double-check that I wrote the DCO for the co-author correctly. Does that look good? Thanks. On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:25 -0500, David Ma

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-02 Thread Antoni Boucher via Gcc-patches
On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > > > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > > > Thanks, David. > > > > Since we're not in phase 1 any

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread David Malcolm via Gcc-patches
On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > > Thanks, David. > > > Since we're not in phase 1 anymore, do we need an approval before > > > I > > > merge like last

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread Antoni Boucher via Gcc-patches
On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > Thanks, David. > > Since we're not in phase 1 anymore, do we need an approval before I > > merge like last year or can I merge immediately? > > I think it counts as a bug fix and

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread David Malcolm via Gcc-patches
On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > Thanks, David. > Since we're not in phase 1 anymore, do we need an approval before I > merge like last year or can I merge immediately? I think it counts as a bug fix and thus you can go ahead and merge (assuming you've done the usual test

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread Antoni Boucher via Gcc-patches
Thanks, David. Since we're not in phase 1 anymore, do we need an approval before I merge like last year or can I merge immediately? I also have many other patches (all in jit) that I need to prepare and post to this mailing list. What do you think? On Thu, 2022-12-01 at 09:28 -0500, David Malcolm

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread David Malcolm via Gcc-patches
On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher via Jit wrote: > Hi. > This fixes bug 107770. > Thanks for the review. Thanks, the patch looks good to me. Dave

Re: [PATCH] libgccjit: Fix float vector comparison

2022-11-30 Thread Antoni Boucher via Gcc-patches
David: PING On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher wrote: > Hi. > This fixes bug 107770. > Thanks for the review.