Re: [PATCH] ipa: Fix throw in multi-versioned functions [PR106627]

2022-09-02 Thread Simon Rainer
Hi, Thanks for committing the patch. I created PR106816 to track the noreturn/pure problem. Regards Simon Rainer On Fri, Sep 2, 2022, at 08:03, Richard Biener wrote: > On Thu, Sep 1, 2022 at 7:51 PM Simon Rainer wrote: > > > > Hi, > > > > Thanks for taking a look at my patch. I tested some com

Re: [PATCH] ipa: Fix throw in multi-versioned functions [PR106627]

2022-09-01 Thread Richard Biener via Gcc-patches
On Thu, Sep 1, 2022 at 7:51 PM Simon Rainer wrote: > > Hi, > > Thanks for taking a look at my patch. I tested some combinations with > pure/noreturn attributes. gcc seems to ignore those attributes on > multiversion functions and generates sub-optimal assembly. > But I wasn't able to fix this by

Re: [PATCH] ipa: Fix throw in multi-versioned functions [PR106627]

2022-09-01 Thread Simon Rainer
Hi, Thanks for taking a look at my patch. I tested some combinations with pure/noreturn attributes. gcc seems to ignore those attributes on multiversion functions and generates sub-optimal assembly. But I wasn't able to fix this by simply copying members like DECL_PURE_P. It's pretty hard for m

Re: [PATCH] ipa: Fix throw in multi-versioned functions [PR106627]

2022-08-31 Thread Richard Biener via Gcc-patches
On Wed, Aug 31, 2022 at 11:00 PM Simon Rainer wrote: > > Hi, > > This patch fixes PR106627. I ran the i386.exp tests on my x86_64-linux-gnu > machine with a fully bootstrapped checkout. I also tested manually that no > exception handling code is generated if none of the function versions throws