Re: [PATCH] ifcvt: Don't make invalid insns for a cond trap (PR78751)

2017-01-14 Thread Jeff Law
On 01/14/2017 10:11 PM, Segher Boessenkool wrote: On Sat, Jan 14, 2017 at 09:23:45PM -0700, Jeff Law wrote: But isn't this a backend failing? ISTM that gen_cond_trap just calls standard expansion routines and they should either have generated a valid sequence or NULL. What in particular genera

Re: [PATCH] ifcvt: Don't make invalid insns for a cond trap (PR78751)

2017-01-14 Thread Segher Boessenkool
On Sat, Jan 14, 2017 at 09:23:45PM -0700, Jeff Law wrote: > But isn't this a backend failing? ISTM that gen_cond_trap just calls > standard expansion routines and they should either have generated a > valid sequence or NULL. > > What in particular generated insn 64 and shouldn't it instead have

Re: [PATCH] ifcvt: Don't make invalid insns for a cond trap (PR78751)

2017-01-14 Thread Jeff Law
On 01/14/2017 06:55 PM, Segher Boessenkool wrote: As shown in the PR, ifcvt will happily make invalid insns when given the chance. This patch teaches it some manners. Bootstrapped and tested on powerpc64-linux. Is this okay for trunk? Segher 2017-01-15 Segher Boessenkool PR rtl