Re: [PATCH] i386: Fix up copysign/xorsign expansion [PR104612]

2022-02-21 Thread Hongtao Liu via Gcc-patches
On Tue, Feb 22, 2022 at 12:46 AM Jakub Jelinek wrote: > > Hi! > > We ICE on the following testcase for -m32 since r12-3435. because > operands[2] is (subreg:SF (reg:DI ...) 0) and According to validate_subreg, (subreg:V4SF (reg:DI ...) 0) should be valid(but not sure if it really works ) For -m64

Re: [PATCH] i386: Fix up copysign/xorsign expansion [PR104612]

2022-02-21 Thread Uros Bizjak via Gcc-patches
On Mon, Feb 21, 2022 at 6:33 PM Jakub Jelinek wrote: > > On Mon, Feb 21, 2022 at 06:01:00PM +0100, Uros Bizjak wrote: > > I remember the same issue in the past, so it looks like the fresh > > pseudo as destination gives RA some more freedom to do its magic. So, > > it is better to do: > > > >

Re: [PATCH] i386: Fix up copysign/xorsign expansion [PR104612]

2022-02-21 Thread Jakub Jelinek via Gcc-patches
On Mon, Feb 21, 2022 at 06:01:00PM +0100, Uros Bizjak wrote: > I remember the same issue in the past, so it looks like the fresh > pseudo as destination gives RA some more freedom to do its magic. So, > it is better to do: > > emit_move_insn (dest, gen_lowpart (wmode, t3)); > > then play wi

Re: [PATCH] i386: Fix up copysign/xorsign expansion [PR104612]

2022-02-21 Thread Uros Bizjak via Gcc-patches
On Mon, Feb 21, 2022 at 5:46 PM Jakub Jelinek wrote: > > Hi! > > We ICE on the following testcase for -m32 since r12-3435. because > operands[2] is (subreg:SF (reg:DI ...) 0) and > lowpart_subreg (V4SFmode, operands[2], SFmode) > returns NULL, and that is what we use in AND etc. insns we emit. > >