Re: [PATCH] hash-table.h: support non-zero empty values in empty_slow

2020-01-10 Thread David Malcolm
On Wed, 2019-12-11 at 17:00 +0100, Jakub Jelinek wrote: > On Wed, Dec 11, 2019 at 10:44:58AM -0500, David Malcolm wrote: > > Is it OK for a hash_map key to have a "empty" value that isn't > > all-zeroes (and thus the same for a hash_table entry)? > > > > Is the following patch OK for trunk? > > I

Re: [PATCH] hash-table.h: support non-zero empty values in empty_slow

2019-12-11 Thread Jakub Jelinek
On Wed, Dec 11, 2019 at 10:44:58AM -0500, David Malcolm wrote: > Is it OK for a hash_map key to have a "empty" value that isn't > all-zeroes (and thus the same for a hash_table entry)? > > Is the following patch OK for trunk? I'd say that it is important to analyze the generated code for the comm