Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread Richard Sandiford via Gcc-patches
Robin Dapp writes: > Ok so the consensus seems to rather stay with 32 bits and only > change the shift to 10/20? Yeah. The check would then be: if (NUM_OPTABS > 0xfff || NUM_MACHINE_MODES > 0x3ff) fatal ("genopinit range assumptions invalid"); > As MACHINE_MODE_BITSIZE is already > 16 we

Re: Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread 钟居哲
Sorry for sending incorrect email. Forget about this:). juzhe.zh...@rivai.ai From: 钟居哲 Date: 2023-07-11 21:55 To: rdapp.gcc; gcc-patches; Jeff Law; richard.sandiford; rguenther CC: rdapp.gcc Subject: Re: [PATCH] genopinit: Allow more than 256 modes. For example: https://godbolt.org/z

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread 钟居哲
For example: https://godbolt.org/z/1d6v5WKhY Clang can vectorize but GCC failed even with -ffast-math. So I think conversions should be well checked again to make sure every variant can vectorize. Thanks. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-07-11 21:31 To: Robin Dapp via Gcc-p

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread Richard Biener via Gcc-patches
On Tue, 11 Jul 2023, ??? wrote: > Thanks for fixing it. > CC Richards to see whether it is appropriate. I agree with Richard S., but generally please avoid 'long long' and use stdint types when you need specific precision. Richard. > > > juzhe.zh...@rivai.ai > > From: Robin Dapp > Date: 202

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread Robin Dapp via Gcc-patches
> if (NUM_OPTABS > 0x > || MAX_MACHINE_MODE >= ((1 << MACHINE_MODE_BITSIZE) - 1)) > fatal ("genopinit range assumptions invalid"); > > so it would be a case of changing those instead. Thanks, right at the beginning of the file and I didn't see it ;) MACHINE_MODE_BITSIZE is already 1

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread Richard Sandiford via Gcc-patches
Richard Sandiford writes: > Robin Dapp via Gcc-patches writes: >> Hi, >> >> upcoming changes for RISC-V will have us exceed 256 modes or 8 bits. The >> helper functions in gen* rely on the opcode as well as two modes fitting >> into an unsigned int (a signed int even if we consider the qsort defa

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread Richard Sandiford via Gcc-patches
Robin Dapp via Gcc-patches writes: > Hi, > > upcoming changes for RISC-V will have us exceed 256 modes or 8 bits. The > helper functions in gen* rely on the opcode as well as two modes fitting > into an unsigned int (a signed int even if we consider the qsort default > comparison function). This

Re: [PATCH] genopinit: Allow more than 256 modes.

2023-07-11 Thread 钟居哲
Thanks for fixing it. CC Richards to see whether it is appropriate. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-07-11 19:51 To: gcc-patches CC: rdapp.gcc; jeffreyalaw; juzhe.zh...@rivai.ai Subject: [PATCH] genopinit: Allow more than 256 modes. Hi, upcoming changes for RISC-V will have u