Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-12-09 Thread Marek Polacek
On Sat, Dec 07, 2024 at 10:01:53AM -0500, Jason Merrill wrote: > On 12/6/24 5:02 PM, Marek Polacek wrote: > > On Mon, Oct 14, 2024 at 03:57:45PM -0400, Jason Merrill wrote: > > > OK. > > > > The patch was approved, but even after the r15-5746 + r15-5747 changes, > > pr78687.C still FAILs: > >

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-12-07 Thread Jason Merrill
On 12/6/24 5:02 PM, Marek Polacek wrote: On Mon, Oct 14, 2024 at 03:57:45PM -0400, Jason Merrill wrote: OK. The patch was approved, but even after the r15-5746 + r15-5747 changes, pr78687.C still FAILs: . Perhaps we should XFAIL the test

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-12-06 Thread Marek Polacek
On Mon, Oct 14, 2024 at 03:57:45PM -0400, Jason Merrill wrote: > OK. The patch was approved, but even after the r15-5746 + r15-5747 changes, pr78687.C still FAILs: . Perhaps we should XFAIL the test for now then. No other changes besides th

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-10-14 Thread Jason Merrill
On 10/7/24 2:45 PM, Marek Polacek wrote: On Wed, Oct 02, 2024 at 05:52:13PM -0400, Jason Merrill wrote: On 10/2/24 3:20 PM, Marek Polacek wrote: On Sat, Sep 28, 2024 at 08:39:12AM +0200, Jakub Jelinek wrote: On Fri, Sep 27, 2024 at 04:01:33PM +0200, Jakub Jelinek wrote: So, I think we should

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-10-07 Thread Marek Polacek
On Wed, Oct 02, 2024 at 05:52:13PM -0400, Jason Merrill wrote: > On 10/2/24 3:20 PM, Marek Polacek wrote: > > On Sat, Sep 28, 2024 at 08:39:12AM +0200, Jakub Jelinek wrote: > > > On Fri, Sep 27, 2024 at 04:01:33PM +0200, Jakub Jelinek wrote: > > > > So, I think we should go with (but so far complet

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-10-03 Thread Jason Merrill
On 9/28/24 2:39 AM, Jakub Jelinek wrote: On Fri, Sep 27, 2024 at 04:01:33PM +0200, Jakub Jelinek wrote: So, I think we should go with (but so far completely untested except for pr78687.C which is optimized with Marek's patch and the above testcase which doesn't have the clearing anymore) the fol

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-10-02 Thread Jason Merrill
On 10/2/24 3:20 PM, Marek Polacek wrote: On Sat, Sep 28, 2024 at 08:39:12AM +0200, Jakub Jelinek wrote: On Fri, Sep 27, 2024 at 04:01:33PM +0200, Jakub Jelinek wrote: So, I think we should go with (but so far completely untested except for pr78687.C which is optimized with Marek's patch and the

Re: [PATCH] expr: Don't clear whole unions [PR116416]

2024-10-02 Thread Marek Polacek
On Sat, Sep 28, 2024 at 08:39:12AM +0200, Jakub Jelinek wrote: > On Fri, Sep 27, 2024 at 04:01:33PM +0200, Jakub Jelinek wrote: > > So, I think we should go with (but so far completely untested except > > for pr78687.C which is optimized with Marek's patch and the above testcase > > which doesn't h