Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread Richard Sandiford
YunQiang Su writes: > Richard Sandiford 于2024年6月5日周三 23:20写道: >> >> YunQiang Su writes: >> > Richard Sandiford 于2024年6月5日周三 22:14写道: >> >> >> >> YunQiang Su writes: >> >> > PR target/113179. >> >> > >> >> > In `store_bit_field_using_insv`, we just use SUBREG if value_mode >> >> >>= op_mode, wh

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread YunQiang Su
Richard Sandiford 于2024年6月5日周三 23:20写道: > > YunQiang Su writes: > > Richard Sandiford 于2024年6月5日周三 22:14写道: > >> > >> YunQiang Su writes: > >> > PR target/113179. > >> > > >> > In `store_bit_field_using_insv`, we just use SUBREG if value_mode > >> >>= op_mode, while in some ports, a sign_extend

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread Jeff Law
On 6/5/24 8:57 AM, YunQiang Su wrote: Richard Sandiford 于2024年6月5日周三 22:14写道: YunQiang Su writes: PR target/113179. In `store_bit_field_using_insv`, we just use SUBREG if value_mode = op_mode, while in some ports, a sign_extend will be needed, such as MIPS64: If either GPR rs or GPR

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread Richard Sandiford
YunQiang Su writes: > Richard Sandiford 于2024年6月5日周三 22:14写道: >> >> YunQiang Su writes: >> > PR target/113179. >> > >> > In `store_bit_field_using_insv`, we just use SUBREG if value_mode >> >>= op_mode, while in some ports, a sign_extend will be needed, >> > such as MIPS64: >> > If either GPR

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread YunQiang Su
Richard Sandiford 于2024年6月5日周三 22:14写道: > > YunQiang Su writes: > > PR target/113179. > > > > In `store_bit_field_using_insv`, we just use SUBREG if value_mode > >>= op_mode, while in some ports, a sign_extend will be needed, > > such as MIPS64: > > If either GPR rs or GPR rt does not contain s

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread Jeff Law
On 6/5/24 8:14 AM, Richard Sandiford wrote: YunQiang Su writes: PR target/113179. In `store_bit_field_using_insv`, we just use SUBREG if value_mode = op_mode, while in some ports, a sign_extend will be needed, such as MIPS64: If either GPR rs or GPR rt does not contain sign-extended 32

Re: [PATCH] expmed: TRUNCATE value1 if needed in store_bit_field_using_insv

2024-06-05 Thread Richard Sandiford
YunQiang Su writes: > PR target/113179. > > In `store_bit_field_using_insv`, we just use SUBREG if value_mode >>= op_mode, while in some ports, a sign_extend will be needed, > such as MIPS64: > If either GPR rs or GPR rt does not contain sign-extended 32-bit > values (bits 63..31 equal), then