Re: [PATCH] error on missing LTO symbols

2018-12-17 Thread Tom de Vries
On 17-12-18 13:46, Martin Jambor wrote: > Hi, > > On Fri, Dec 14 2018, Jakub Jelinek wrote: >> On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >>> --- /dev/null >>> +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c >>> @@ -0,0 +1,21 @@ >>> +/* { dg-do link } */ >>

Re: [PATCH] error on missing LTO symbols

2018-12-17 Thread Martin Jambor
Hi, On Fri, Dec 14 2018, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> --- /dev/null >> +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c >> @@ -0,0 +1,21 @@ >> +/* { dg-do link } */ >> +/* { dg-excess-errors "lto1, mkoffload and lto-wr

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Jakub Jelinek
On Fri, Dec 14, 2018 at 02:17:49PM +0100, Tom de Vries wrote: > Build x86_64 and reg-tested libgomp. > > 2018-12-13 Tom de Vries > > * lto-cgraph.c (verify_node_partition): New function. > (input_overwrite_node, input_varpool_node): Use verify_node_partition. > > * testsuite

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Tom de Vries
On 14-12-18 14:08, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: >> Done, using offload_device_nonshared_as for >> libgomp.c-c++-common/variable-not-offloaded.c and >> openacc_nvidia_accel_configured for >> libgomp.oacc-c-c++-common/function-not-offloaded.c. >

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Jakub Jelinek
On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: > Done, using offload_device_nonshared_as for > libgomp.c-c++-common/variable-not-offloaded.c and > openacc_nvidia_accel_configured for > libgomp.oacc-c-c++-common/function-not-offloaded.c. > > > Otherwise LGTM. > > Updated patch OK?

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Tom de Vries
[ cc-ing HSAIL maintainer ] On 14-12-18 10:54, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> Build and reg-tested on x86_64 with nvptx accelerator. >> >> 2018-12-13 Tom de Vries >> >> * lto-cgraph.c (verify_node_partition): New function. >> (i

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Thomas Schwinge
Hi Tom! Thanks for looking into this one! Just one quick comment: On Fri, 14 Dec 2018 10:21:35 +0100, Tom de Vries wrote: > --- a/gcc/lto-cgraph.c > +++ b/gcc/lto-cgraph.c > +#ifdef ACCEL_COMPILER > + if (in_other_partition) > +{ > + if (TREE_CODE (decl) == FUNCTION_DECL > + ||

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Jakub Jelinek
On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c > @@ -0,0 +1,21 @@ > +/* { dg-do link } */ > +/* { dg-excess-errors "lto1, mkoffload and lto-wrapper fatal errors" } */ > + > +int results[2000]; /*

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Jakub Jelinek
On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: > Build and reg-tested on x86_64 with nvptx accelerator. > > 2018-12-13 Tom de Vries > > * lto-cgraph.c (verify_node_partition): New function. > (input_overwrite_node, input_varpool_node): Use verify_node_partition. > >

Re: [PATCH] error on missing LTO symbols

2018-12-14 Thread Tom de Vries
On 13-12-18 14:44, Jakub Jelinek wrote: > On Thu, Dec 13, 2018 at 02:31:45PM +0100, Tom de Vries wrote: >>> 2015-07-24 Cesar Philippidis > > Please use current date ;) > >>> >>> gcc/ >>> * lto-cgraph.c (input_overwrite_node): Error instead of assert >>> on missing cgraph partitions

Re: [PATCH] error on missing LTO symbols

2018-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2018 at 02:31:45PM +0100, Tom de Vries wrote: > > 2015-07-24 Cesar Philippidis Please use current date ;) > > > > gcc/ > > * lto-cgraph.c (input_overwrite_node): Error instead of assert > > on missing cgraph partitions. > > (input_varpool_node): Likewise. > >

Re: [PATCH] error on missing LTO symbols

2018-12-13 Thread Tom de Vries
[ adding gcc-patches ] On 13-12-18 14:30, Tom de Vries wrote: > [ Patch copy-pasted from here ( > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02076.html ). Patch was > resubmitted here ( > https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00043.html ). ] > > Hi, > > this issue just popped up again