Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Martin Liška
On 4/12/21 3:50 PM, H.J. Lu wrote: > GCC failed to bootstrap: > > /export/gnu/import/git/sources/gcc/gcc/doc/extend.texi:3870: misplaced { > /export/gnu/import/git/sources/gcc/gcc/doc/extend.texi:3872: misplaced } > /export/gnu/import/git/sources/gcc/gcc/doc/extend.texi:3874: unknown > command `VE

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread H.J. Lu via Gcc-patches
On Mon, Apr 12, 2021 at 5:54 AM Martin Liška wrote: > > On 4/12/21 2:18 PM, Jakub Jelinek wrote: > > On Mon, Apr 12, 2021 at 02:15:16PM +0200, Martin Liška wrote: > >> The old syntax with the alias is quite ugly.. > > > > Not that much. And users have no other option (besides inline asm > > but t

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 12, 2021 at 03:24:00PM +0200, Martin Liška wrote: > On 4/12/21 2:45 PM, Jakub Jelinek wrote: > > On Mon, Apr 12, 2021 at 02:32:35PM +0200, Martin Liška wrote: > >> +If you have an older release of binutils release, then symbol alias needs > >> to > > > > s/binutils release/binutils/ >

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Martin Liška
On 4/12/21 2:45 PM, Jakub Jelinek wrote: > On Mon, Apr 12, 2021 at 02:32:35PM +0200, Martin Liška wrote: >> +If you have an older release of binutils release, then symbol alias needs to > > s/binutils release/binutils/ Fixed. > >> +be used: >> + >> +@smallexample >> +__attribute__ ((__symver__

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 12, 2021 at 02:32:35PM +0200, Martin Liška wrote: > +If you have an older release of binutils release, then symbol alias needs to s/binutils release/binutils/ > +be used: > + > +@smallexample > +__attribute__ ((__symver__ ("foo@@VERS_2"))) > +__attribute__ ((alias ("foo_v1"))) > +int

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Martin Liška
On 4/12/21 2:18 PM, Jakub Jelinek wrote: > On Mon, Apr 12, 2021 at 02:15:16PM +0200, Martin Liška wrote: >> The old syntax with the alias is quite ugly.. > > Not that much. And users have no other option (besides inline asm > but that doesn't work with LTO well). > >>> so that people who don't h

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 12, 2021 at 02:15:16PM +0200, Martin Liška wrote: > The old syntax with the alias is quite ugly.. Not that much. And users have no other option (besides inline asm but that doesn't work with LTO well). > > so that people who don't have gcc configured against > > binutils 2.35 or newe

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Martin Liška
On 4/12/21 1:50 PM, Jakub Jelinek wrote: > On Mon, Apr 12, 2021 at 01:44:54PM +0200, Martin Liška wrote: >> This improves documentation as noticed by Jakub. >> >> Ready for master? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> * doc/extend.texi: Be more precise in documentation >> of sy

Re: [PATCH] docs: update symver attribute description

2021-04-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 12, 2021 at 01:44:54PM +0200, Martin Liška wrote: > This improves documentation as noticed by Jakub. > > Ready for master? > Thanks, > Martin > > gcc/ChangeLog: > > * doc/extend.texi: Be more precise in documentation > of symver attribute. Ok, but I'd prefer to see the o