Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Wed, Jun 30, 2021 at 11:00 AM Richard Sandiford wrote: > > Richard Biener via Gcc-patches writes: > > Note there's also array_slice<> which could be used to pass non-const > > vec<>s that are never resized but modified - the only "valid" case of > > passing a non-const vec<> by value. > > Yeah

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Martin Jambor
Hi, On Wed, Jun 30 2021, Richard Biener wrote: > On Wed, Jun 30, 2021 at 3:46 AM Martin Sebor wrote: >> On 6/29/21 4:58 AM, Richard Biener wrote: [...] >> > >> > But I wonder if since you now identified them they could be massaged >> > prior to doing the change. >> > >> > I do hope we end up no

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > Note there's also array_slice<> which could be used to pass non-const > vec<>s that are never resized but modified - the only "valid" case of > passing a non-const vec<> by value. Yeah. We'd need a new constructor for that (the current one only takes cons

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Wed, Jun 30, 2021 at 3:46 AM Martin Sebor wrote: > > On 6/29/21 4:58 AM, Richard Biener wrote: > > On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: > >> > >> On 6/28/21 2:07 AM, Richard Biener wrote: > >>> On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11 P

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Tue, Jun 29, 2021 at 7:18 PM Martin Sebor wrote: > > On 6/29/21 8:43 AM, Jason Merrill wrote: > > On 6/28/21 2:07 PM, Martin Sebor wrote: > >> On 6/28/21 2:07 AM, Richard Biener wrote: > >>> On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11 PM, Jason Merrill wr

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Sebor via Gcc-patches
On 6/29/21 4:58 AM, Richard Biener wrote: On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Sebor via Gcc-patches
On 6/29/21 8:43 AM, Jason Merrill wrote: On 6/28/21 2:07 PM, Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Jason Merrill via Gcc-patches
On 6/28/21 2:07 PM, Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wr

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Trevor Saunders
On Fri, Jun 25, 2021 at 02:51:58PM -0600, Martin Sebor via Gcc-patches wrote: > On 6/1/21 3:38 PM, Jason Merrill wrote: > > On 6/1/21 3:56 PM, Martin Sebor wrote: > > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > > > > > On 4/27/21 8:0

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Jambor
Hi, On Tue, Jun 29 2021, Richard Biener via Gcc-patches wrote: > On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: [...] >> >> vNULL can bind to a const vec& (via the vec conversion ctor) but >> not to vec&. The three functions that in the patch are passed >> vNULL modify the argument when i

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Richard Biener via Gcc-patches
On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: > > On 6/28/21 2:07 AM, Richard Biener wrote: > > On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > >> > >> On 6/25/21 4:11 PM, Jason Merrill wrote: > >>> On 6/25/21 4:51 PM, Martin Sebor wrote: > On 6/1/21 3:38 PM, Jason Merrill wrote

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Martin Sebor via Gcc-patches
On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill w

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Richard Biener via Gcc-patches
On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11 PM, Jason Merrill wrote: > > On 6/25/21 4:51 PM, Martin Sebor wrote: > >> On 6/1/21 3:38 PM, Jason Merrill wrote: > >>> On 6/1/21 3:56 PM, Martin Sebor wrote: > On 5/27/21 2:53 PM, Jason Merrill wrote: > > On 4/27/21

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Richard Biener via Gcc-patches
On Fri, Jun 25, 2021 at 10:52 PM Martin Sebor wrote: > > On 6/1/21 3:38 PM, Jason Merrill wrote: > > On 6/1/21 3:56 PM, Martin Sebor wrote: > >> On 5/27/21 2:53 PM, Jason Merrill wrote: > >>> On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > On 4/27/21 8:04 AM, Richard Biener wrote:

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Martin Sebor via Gcc-patches
On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Jason Merrill via Gcc-patches
On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Ma

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Martin Sebor via Gcc-patches
On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-08 Thread Richard Biener via Gcc-patches
On Tue, Jun 8, 2021 at 5:26 AM Trevor Saunders wrote: > > On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > > On 6/7/21 2:51 AM, Richard Biener wrote: > > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > > wrote: > > > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > On 6/7/21 2:51 AM, Richard Biener wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > > wrote: > > > > On 6/2/21 12:55 AM, Ric

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 04:17:09PM -0600, Martin Sebor wrote: > On 6/3/21 2:29 AM, Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/3/21 2:29 AM, Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/7/21 2:51 AM, Richard Biener wrote: On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Ja

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 12:33 PM Trevor Saunders wrote: > > On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches > wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > > w

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches wrote: > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun 1,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote:

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-03 Thread Trevor Saunders
On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > On 6/2/21 12:55 AM, Richard Biener wrote: > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-02 Thread Martin Sebor via Gcc-patches
On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-01 Thread Richard Biener via Gcc-patches
On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > >> On 4/27/21 8:04 AM, Richard Biener wrote: > >>> On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: > > On 4/27/21 1:58 AM, R

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-01 Thread Jason Merrill via Gcc-patches
On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-01 Thread Martin Sebor via Gcc-patches
On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patc

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-05-27 Thread Jason Merrill via Gcc-patches
On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that auto_vec

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Martin Sebor via Gcc-patches
On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that auto_vec is unsafe to copy and assign because the class manages it

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Richard Biener via Gcc-patches
On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: > > On 4/27/21 1:58 AM, Richard Biener wrote: > > On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches > > wrote: > >> > >> PR 90904 notes that auto_vec is unsafe to copy and assign because > >> the class manages its own memory but doesn

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Martin Sebor via Gcc-patches
On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that auto_vec is unsafe to copy and assign because the class manages its own memory but doesn't define (or delete) either special function. Since I first ran into the p

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Richard Biener via Gcc-patches
On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: > > PR 90904 notes that auto_vec is unsafe to copy and assign because > the class manages its own memory but doesn't define (or delete) > either special function. Since I first ran into the problem, > auto_vec has grown a move ct