On May 11, 2022, Martin Liška wrote:
> Ready to be installed?
Hmm... I don't like that --disable-fixincludes would still configure,
build and even install fixincludes. This would be surprising, given
that the semantics of disabling a component is to not even configure it.
How about leaving th
On 5/11/22 14:48, Andreas Schwab wrote:
> On Mai 11 2022, Martin Liška wrote:
>
>> @Joseph: Can you please help me why --disable-$foo disables building $foo
>> folder during the build?
>
> # Handle --disable- generically.
> for dir in $configdirs $build_configdirs $target_configdirs ; do
> dirn
On Mai 11 2022, Martin Liška wrote:
> @Joseph: Can you please help me why --disable-$foo disables building $foo
> folder during the build?
# Handle --disable- generically.
for dir in $configdirs $build_configdirs $target_configdirs ; do
dirname=`echo $dir | sed -e s/target-//g -e s/build-//g -e
On 5/11/22 13:31, Rainer Orth wrote:
> Hi Martin,
>
Subject: [PATCH] configure: add --disable-fix-includes
>>>
>>> As I've mentioned before, I believe, the command is called fixincludes
>>> in current gcc docs, and the option should reflect that, not introduce a
>>> name used nowhere else.
>>
Hi Martin,
>>> Subject: [PATCH] configure: add --disable-fix-includes
>>
>> As I've mentioned before, I believe, the command is called fixincludes
>> in current gcc docs, and the option should reflect that, not introduce a
>> name used nowhere else.
>
> No, I can't use it, because even with curre
On 5/11/22 13:00, Rainer Orth wrote:
> Hi Martin,
>
>> On 5/9/22 23:14, Joseph Myers wrote:
>>> If you add a new configure option, it should be documented in
>>> install.texi.
>>>
>>
>> Both comments fixed in the v2.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
Hi Martin,
> On 5/9/22 23:14, Joseph Myers wrote:
>> If you add a new configure option, it should be documented in
>> install.texi.
>>
>
> Both comments fixed in the v2.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> From 58d431568d6b6163dd9cdc920239f173689a769c Mon
On 5/9/22 23:14, Joseph Myers wrote:
> If you add a new configure option, it should be documented in
> install.texi.
>
Both comments fixed in the v2.
Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
Ready to be installed?
Thanks,
MartinFrom 58d431568d6b6163dd9cdc920239f17
If you add a new configure option, it should be documented in
install.texi.
--
Joseph S. Myers
jos...@codesourcery.com
On Mai 09 2022, Martin Liška wrote:
> +cat >>confdefs.h <<_ACEOF
> +#define FIX_INCLUDES $disable_fix_includes
> +_ACEOF
Where does this come from? Also, nothing uses it.
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 1171c946e6e..6015e403aa9 100644
> --- a/gcc/configure.ac
> +++ b/
On 2/5/22 03:26, Allan McRae wrote:
On 5/2/22 01:22, Martin Liška wrote:
On 2/4/22 14:30, Jakub Jelinek via Gcc-patches wrote:
We don't ship any include-fixed headers in Fedora/RHEL.
Removing include-fixed from an installed folder, I see:
make[2]: Entering directory '/home/marxin/Programming
On 5/2/22 01:22, Martin Liška wrote:
On 2/4/22 14:30, Jakub Jelinek via Gcc-patches wrote:
We don't ship any include-fixed headers in Fedora/RHEL.
Removing include-fixed from an installed folder, I see:
make[2]: Entering directory '/home/marxin/Programming/postgres/src/common'
gcc -Wall -Wmis
On 2/4/22 14:30, Jakub Jelinek via Gcc-patches wrote:
We don't ship any include-fixed headers in Fedora/RHEL.
Removing include-fixed from an installed folder, I see:
make[2]: Entering directory '/home/marxin/Programming/postgres/src/common'
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdecl
On 2/4/22 14:07, Rainer Orth wrote:
Hi Martin,
It seems to me that fixincludes is hardy unused feature for nowadays header
files and so I'm suggesting a developer option that can skip the fixing.
please remember that there's a world beyond current-day Linux.
Sure! That's why I'm suggesting
On 2/4/22 14:30, Jakub Jelinek via Gcc-patches wrote:
On Fri, Feb 04, 2022 at 02:25:17PM +0100, Richard Biener via Gcc-patches wrote:
Besides, have you actually run a regtest with that option? I'm asking
because even on Ubuntu 20.04 fixincludes drops in it's own .
You need to check that droppin
On Fri, Feb 04, 2022 at 02:25:17PM +0100, Richard Biener via Gcc-patches wrote:
> > Besides, have you actually run a regtest with that option? I'm asking
> > because even on Ubuntu 20.04 fixincludes drops in it's own .
> > You need to check that dropping that is actually safe.
>
> limits.h and sy
On Fri, Feb 4, 2022 at 2:08 PM Rainer Orth
wrote:
>
> Hi Martin,
>
> > It seems to me that fixincludes is hardy unused feature for nowadays header
> > files and so I'm suggesting a developer option that can skip the fixing.
>
> please remember that there's a world beyond current-day Linux.
>
> >
Hi Martin,
> It seems to me that fixincludes is hardy unused feature for nowadays header
> files and so I'm suggesting a developer option that can skip the fixing.
please remember that there's a world beyond current-day Linux.
> How is the feature used on other targets?
There are still quite a
18 matches
Mail list logo
