Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-24 Thread Jeff Law
On 2/24/25 9:43 AM, Michael Matz wrote: It depends, but even if that were no problem in some specific cases (perhaps by ensuring that such sequence isn't intermingled with insns that are in different EH regions) that doesn't seem to be what the proposal is doing? From the description it mov

Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-24 Thread Michael Matz
Hello, On Mon, 24 Feb 2025, Jeff Law wrote: > The pass rejects the transformation when there are instructions in the > sequence that might throw an exception. This was added due to having > cases that the load instruction contains a REG_EH_REGION note and > moving it before th

Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-24 Thread Jeff Law
On 2/24/25 2:23 AM, Richard Biener wrote: On Fri, Feb 21, 2025 at 4:55 PM Konstantinos Eleftheriou wrote: Hi Richard, thanks for the feedback. On Tue, Feb 18, 2025 at 9:17 PM Richard Biener wrote: Am 18.02.2025 um 17:04 schrieb Konstantinos Eleftheriou : From: kelefth The pass r

Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-24 Thread Richard Biener
On Fri, Feb 21, 2025 at 4:55 PM Konstantinos Eleftheriou wrote: > > Hi Richard, thanks for the feedback. > > On Tue, Feb 18, 2025 at 9:17 PM Richard Biener > wrote: > > > > > > > > > Am 18.02.2025 um 17:04 schrieb Konstantinos Eleftheriou > > > : > > > > > > From: kelefth > > > > > > The pass

Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-21 Thread Konstantinos Eleftheriou
Hi Richard, thanks for the feedback. On Tue, Feb 18, 2025 at 9:17 PM Richard Biener wrote: > > > > > Am 18.02.2025 um 17:04 schrieb Konstantinos Eleftheriou > > : > > > > From: kelefth > > > > The pass rejects the transformation when there are instructions in the > > sequence that might throw

Re: [PATCH] avoid-store-forwarding: Handle REG_EH_REGION notes

2025-02-18 Thread Richard Biener
> Am 18.02.2025 um 17:04 schrieb Konstantinos Eleftheriou > : > > From: kelefth > > The pass rejects the transformation when there are instructions in the > sequence that might throw an exception. This was added due to having > cases that the load instruction contains a REG_EH_REGION note a