Re: [PATCH] analyzer: remove dead code

2021-03-02 Thread Martin Liška
On 3/2/21 2:38 PM, David Malcolm wrote: On Tue, 2021-03-02 at 11:38 +0100, Martin Liška wrote: The issue is reported by Clang: warning: private field 'm_engine' is not used [-Wunused-private- field] Thanks; FWIW I think I removed the usage in a505fad4dd4d93b6d642995d7df320aa40949568. Good!

Re: [PATCH] analyzer: remove dead code

2021-03-02 Thread David Malcolm via Gcc-patches
On Tue, 2021-03-02 at 11:38 +0100, Martin Liška wrote: > The issue is reported by Clang: > > warning: private field 'm_engine' is not used [-Wunused-private- > field] Thanks; FWIW I think I removed the usage in a505fad4dd4d93b6d642995d7df320aa40949568. LGTM Dave

Re: [PATCH] analyzer: remove dead code

2020-11-10 Thread Jeff Law via Gcc-patches
On 11/10/20 9:57 AM, David Malcolm via Gcc-patches wrote: > On Fri, 2020-10-23 at 17:26 +0200, Martin Liška wrote: >> Hey. >> >> I've noticed that when building GCC with Clang. >> David what do you think about it? > Thanks for the patch. > > Looks good to me, assuming it goes through normal boots

Re: [PATCH] analyzer: remove dead code

2020-11-10 Thread David Malcolm via Gcc-patches
On Fri, 2020-10-23 at 17:26 +0200, Martin Liška wrote: > Hey. > > I've noticed that when building GCC with Clang. > David what do you think about it? Thanks for the patch. Looks good to me, assuming it goes through normal bootstrap and regression-testing. That said, technically I'm not a mainta

Re: [PATCH] analyzer: remove dead code

2020-11-09 Thread Martin Liška
PING^1 On 10/23/20 5:26 PM, Martin Liška wrote: Hey. I've noticed that when building GCC with Clang. David what do you think about it? Thanks, Martin gcc/analyzer/ChangeLog: * constraint-manager.cc (constraint_manager::merge): Remove unused code. * constraint-manager.h: Likewi