Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Jason Merrill
OK. Jason

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Marek Polacek
On Tue, Sep 24, 2013 at 12:00:41PM -0500, Paolo Carlini wrote: > Hi, > > On 9/24/13 11:35 AM, Marek Polacek wrote: > >I admit I haven't spent much time on this, but it seems we should just > >check whether we can set the expr location before actually setting it... > > > >Regtested/bootstrapped on

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Paolo Carlini
Hi, On 9/24/13 11:35 AM, Marek Polacek wrote: I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on x86_64-linux, ok for trunk? Two minor nits (assuming the general idea makes se