Re: [PATCH] Respect user align for local variable

2020-03-30 Thread Kito Cheng
Hi Jakub: Thanks for your correction, I read the doc for the aligned attribute again[1], it's minimum alignment not restricted alignment, I thought it should honor to the alignment attribute, Richard Biener suggested[2] should put an assertion here to make sure never decrease alignment here, so I'

Re: [PATCH] Respect user align for local variable

2020-03-30 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 30, 2020 at 06:31:27PM +0800, Kito Cheng wrote: > gcc/ChangeLog > > * cfgexpand.c (align_local_variable): Check DECL_USER_ALIGN. Why? LOCAL_DECL_ALIGNMENT surely shouldn't decrease alignment of decls with DECL_USER_ALIGN vars (but do you have evidence that it does), but it is j