Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 02:36:11PM -0400, Michael Meissner wrote: > On Wed, Jul 03, 2019 at 12:55:41PM -0500, Segher Boessenkool wrote: > > I don't think this is a good idea. You can set "cost" directly, if that > > is the only thing you need this for? > > The trouble is the cost is currently a f

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 01:06:27PM -0400, Michael Meissner wrote: > On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > > > @@ -7385,8 +7385,8 @@ (define_insn "*mov_softfloat" > > > *, *, *, *") > > > > > > (set_attr "length" > > > - "4,

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Wed, Jul 03, 2019 at 12:55:41PM -0500, Segher Boessenkool wrote: > On Wed, Jul 03, 2019 at 12:50:37PM -0400, Michael Meissner wrote: > > On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > > > We'll need to update our insn_cost for prefixed, sure, it currently does > > > int

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 12:50:37PM -0400, Michael Meissner wrote: > On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > > We'll need to update our insn_cost for prefixed, sure, it currently does > > int n = get_attr_length (insn) / 4; > > to figure out how many machine instructi

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > Hi Mike, > > Sorry I missed this patch :-( > > On Thu, Jun 27, 2019 at 04:18:00PM -0400, Michael Meissner wrote: > > As we discussed off-line earlier, I changed all of the "4" lengths to be > > "*", > > even for instruction al

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > On Tue, Jul 02, 2019 at 07:36:21PM -0400, Michael Meissner wrote: > > On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > > > The entry before the 8 is split as well. Maybe that should be "4", to > > > stand ou

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-02 Thread Segher Boessenkool
On Tue, Jul 02, 2019 at 07:36:21PM -0400, Michael Meissner wrote: > On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > > The entry before the 8 is split as well. Maybe that should be "4", to > > stand out? I don't know what works better; your choice. > > I'll look into it. No

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-02 Thread Michael Meissner
On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > The entry before the 8 is split as well. Maybe that should be "4", to > stand out? I don't know what works better; your choice. I'll look into it. Note, the length is used in two places. One at the end to generate the approp

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-01 Thread Segher Boessenkool
Hi Mike, Sorry I missed this patch :-( On Thu, Jun 27, 2019 at 04:18:00PM -0400, Michael Meissner wrote: > As we discussed off-line earlier, I changed all of the "4" lengths to be "*", > even for instruction alternatives that would not be subject to being changed > to > be a prefixed instruction