Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Torvald Riegel
On Thu, 2013-01-24 at 21:44 +0400, Dmitry Vyukov wrote: > On Thu, Jan 24, 2013 at 9:29 PM, Torvald Riegel wrote: > > On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: > >> > I think the simplest way to solve it for now, it to use... well, single > >> > global lock. > >> > I.e. replace __txn

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Dmitry Vyukov
On Thu, Jan 24, 2013 at 9:29 PM, Torvald Riegel wrote: > On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: >> resend in plain text >> >> On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov wrote: >> > >> > On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel wrote: >> > > On Thu, 2012-12-13 at 10:02

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2013-01-24 Thread Torvald Riegel
On Mon, 2012-12-17 at 13:52 +0400, Dmitry Vyukov wrote: > resend in plain text > > On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov wrote: > > > > On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel wrote: > > > On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: > > >> On Thu, Dec 13, 2012 at 10:

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-17 Thread Dmitry Vyukov
resend in plain text On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov wrote: > > On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel wrote: > > On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: > >> On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: > >> > On Wed, Dec 12, 2012 at 11:

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Torvald Riegel
On Thu, 2012-12-13 at 10:40 +0400, Dmitry Vyukov wrote: > On Thu, Dec 13, 2012 at 1:58 AM, Richard Henderson wrote: > > On 12/12/2012 11:50 AM, Jakub Jelinek wrote: > >> 2012-12-12 Jakub Jelinek > >> > >> PR sanitizer/55508 > >> * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, >

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Torvald Riegel
On Fri, 2012-12-14 at 13:44 +0400, Dmitry Vyukov wrote: > On Thu, Dec 13, 2012 at 1:02 PM, Jakub Jelinek wrote: > >> > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > >> > The problem is that asan.c pass adds calls to builtins that weren't there > >> > before and TM is upset a

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Torvald Riegel
On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: > On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: > > On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek wrote: > > > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > > > The problem is that asan.c pass adds ca

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-14 Thread Dmitry Vyukov
On Thu, Dec 13, 2012 at 1:02 PM, Jakub Jelinek wrote: >> > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. >> > The problem is that asan.c pass adds calls to builtins that weren't there >> > before and TM is upset about it. The __asan_report* are all like >> > abort, in correct

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: > On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek wrote: > > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > > The problem is that asan.c pass adds calls to builtins that weren't there > > before and TM is upset ab

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dmitry Vyukov
On Thu, Dec 13, 2012 at 1:58 AM, Richard Henderson wrote: > On 12/12/2012 11:50 AM, Jakub Jelinek wrote: >> 2012-12-12 Jakub Jelinek >> >> PR sanitizer/55508 >> * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, >> ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): New. >> * asan

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dmitry Vyukov
On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek wrote: > Hi! > > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > The problem is that asan.c pass adds calls to builtins that weren't there > before and TM is upset about it. The __asan_report* are all like > abort, in correctly

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Richard Henderson
On 12/12/2012 11:50 AM, Jakub Jelinek wrote: > 2012-12-12 Jakub Jelinek > > PR sanitizer/55508 > * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, > ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): New. > * asan.c (ATTR_TMPURE_NOTHROW_LEAF_LIST, > ATTR_TMPURE_NORETURN_NO

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Jack Howarth
On Wed, Dec 12, 2012 at 08:50:33PM +0100, Jakub Jelinek wrote: > Hi! > > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > The problem is that asan.c pass adds calls to builtins that weren't there > before and TM is upset about it. The __asan_report* are all like > abort, in co

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-12 Thread Dodji Seketeli
Jakub Jelinek writes: > PR sanitizer/55508 > * builtin-attrs.def (ATTR_TMPURE_NOTHROW_LEAF_LIST, > ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): New. > * asan.c (ATTR_TMPURE_NOTHROW_LEAF_LIST, > ATTR_TMPURE_NORETURN_NOTHROW_LEAF_LIST): Define. > * sanitizer.def: Mak