Re: [PATCH] Make mergeable read-only sections per-function, if requested.

2015-05-07 Thread Segher Boessenkool
On Thu, May 07, 2015 at 07:31:33AM -0600, Jeff Law wrote: > If you could cobble together a little test (ppc specific is fine with > me) it'd be appreciated. > > With that, approved for the trunk. I did one for *-*-linux*. Tested on powerpc64-linux and x86_64-linux. Committed. Segher 2015-05

Re: [PATCH] Make mergeable read-only sections per-function, if requested.

2015-05-07 Thread Jeff Law
On 05/07/2015 06:30 AM, Segher Boessenkool wrote: On Thu, May 07, 2015 at 10:15:08AM +0200, Marek Polacek wrote: +const char * +function_mergeable_rodata_prefix (void) This function needs a comment. And much more importantly, I forgot to make it static. Fixed. +{ + section *s = targetm.a

Re: [PATCH] Make mergeable read-only sections per-function, if requested.

2015-05-07 Thread Jeff Law
On 05/07/2015 02:15 AM, Marek Polacek wrote: On Wed, May 06, 2015 at 03:59:33PM -0700, Segher Boessenkool wrote: Currently GCC does not put mergeable read-only data in a per-function section, so the -gc-sections linker option does not do much for such data. Fix that. Dunno if it is a good ide

Re: [PATCH] Make mergeable read-only sections per-function, if requested.

2015-05-07 Thread Segher Boessenkool
On Thu, May 07, 2015 at 10:15:08AM +0200, Marek Polacek wrote: > > +const char * > > +function_mergeable_rodata_prefix (void) > > This function needs a comment. And much more importantly, I forgot to make it static. Fixed. > > +{ > > + section *s = targetm.asm_out.function_rodata_section > >

Re: [PATCH] Make mergeable read-only sections per-function, if requested.

2015-05-07 Thread Marek Polacek
On Wed, May 06, 2015 at 03:59:33PM -0700, Segher Boessenkool wrote: > Currently GCC does not put mergeable read-only data in a per-function > section, so the -gc-sections linker option does not do much for such > data. Fix that. Dunno if it is a good idea, but... > diff --git a/gcc/varasm.c b/gc