Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-04-18 Thread H.J. Lu
On Mon, Jan 6, 2014 at 7:20 AM, Jakub Jelinek wrote: > On Sat, Jan 04, 2014 at 12:37:57AM +0100, Jakub Jelinek wrote: >> That is certainly doable (as attached), but strangely if the patch (that I've >> already committed) is reverted and this one applied, the .text savings are >> much smaller. >> >

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-06 Thread Jakub Jelinek
On Sat, Jan 04, 2014 at 12:37:57AM +0100, Jakub Jelinek wrote: > That is certainly doable (as attached), but strangely if the patch (that I've > already committed) is reverted and this one applied, the .text savings are > much smaller. > > Here are .text and .rodata readelf -WS lines from x86_64 (

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Andrew Pinski
On Fri, Jan 3, 2014 at 6:27 PM, Andrew Pinski wrote: > On Fri, Jan 3, 2014 at 3:37 PM, Jakub Jelinek wrote: >> On Fri, Jan 03, 2014 at 03:39:11PM +, Joseph S. Myers wrote: >>> On Fri, 3 Jan 2014, Jakub Jelinek wrote: >>> >>> > I've noticed that especially with the AVX512F introduction we use

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Andrew Pinski
On Fri, Jan 3, 2014 at 3:37 PM, Jakub Jelinek wrote: > On Fri, Jan 03, 2014 at 03:39:11PM +, Joseph S. Myers wrote: >> On Fri, 3 Jan 2014, Jakub Jelinek wrote: >> >> > I've noticed that especially with the AVX512F introduction we use >> > GET_MODE_SIZE (mode) quite heavily in the i386 *.md fil

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Jakub Jelinek
On Fri, Jan 03, 2014 at 03:39:11PM +, Joseph S. Myers wrote: > On Fri, 3 Jan 2014, Jakub Jelinek wrote: > > > I've noticed that especially with the AVX512F introduction we use > > GET_MODE_SIZE (mode) quite heavily in the i386 *.md files, and > > the problem with that is GET_MODE_SIZE isn't a

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Joseph S. Myers
On Fri, 3 Jan 2014, Jakub Jelinek wrote: > I've noticed that especially with the AVX512F introduction we use > GET_MODE_SIZE (mode) quite heavily in the i386 *.md files, and > the problem with that is GET_MODE_SIZE isn't a compile time constant, > needs to read mode_size array (non-const) at runti

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Uros Bizjak
On Fri, Jan 3, 2014 at 9:48 AM, Jakub Jelinek wrote: > I've noticed that especially with the AVX512F introduction we use > GET_MODE_SIZE (mode) quite heavily in the i386 *.md files, and > the problem with that is GET_MODE_SIZE isn't a compile time constant, > needs to read mode_size array (non-co