Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-20 Thread Yury Gribov
> The new test fails on x86_64 Ubuntu 12.04 native build: Yes, this should be fixed once kcc's patches get into trunk (https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00756.html). Current asan_interface.h is indeed C++-only. -Y

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-20 Thread Maxim Kuvyrkov
On May 14, 2014, at 4:13 AM, Yury Gribov wrote: > Hi, > > Asan and Tsan allow sanitized applications to tweak runtime behavior via API > defined in headers in libsanitizer/include/sanitizer. This patch adds > installation code for these headers and a small test. > > Bootstrapped and regtested

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-14 Thread Yury Gribov
On 05/14/2014 10:46 AM, Jakub Jelinek wrote: Ok. Thanks, submitted in r210413. -Y

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-14 Thread Konstantin Serebryany
On Wed, May 14, 2014 at 11:47 AM, Yury Gribov wrote: > On 05/14/2014 10:29 AM, Konstantin Serebryany wrote: >>> >>> Well, I'd say we should only install headers for components that are >>> supported by target platform. >> >> maybe yes. It just complicates the patch somewhat. > > > True... But this

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-14 Thread Yury Gribov
On 05/14/2014 10:29 AM, Konstantin Serebryany wrote: Well, I'd say we should only install headers for components that are supported by target platform. maybe yes. It just complicates the patch somewhat. True... But this seems to be the preferred way in GCC (other runtimes also list headers ex

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Jakub Jelinek
On Tue, May 13, 2014 at 08:13:07PM +0400, Yury Gribov wrote: > Asan and Tsan allow sanitized applications to tweak runtime behavior > via API defined in headers in libsanitizer/include/sanitizer. This > patch adds installation code for these headers and a small test. > > Bootstrapped and regtested

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Konstantin Serebryany
On Wed, May 14, 2014 at 9:18 AM, Yury Gribov wrote: > On 05/14/2014 08:54 AM, Konstantin Serebryany wrote: >> Shouldn't we just install the entire include/sanitizer directory? > > Well, I'd say we should only install headers for components that are > supported by target platform. maybe yes. It jus

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Yury Gribov
On 05/14/2014 08:54 AM, Konstantin Serebryany wrote: > Shouldn't we just install the entire include/sanitizer directory? Well, I'd say we should only install headers for components that are supported by target platform. -Y

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Yury Gribov
> Bootstrapped and regtested on x64. Forgot to mention: the newly added test currently fails for C because of C++-isms in asan_interface.h but this should be fixed with next merge from LLVM. -Y

Re: [PATCH] Install sanitizer public headers (fix for PR sanitizer/61100)

2014-05-13 Thread Konstantin Serebryany
Shouldn't we just install the entire include/sanitizer directory? (And thanks for doing this!!) On Tue, May 13, 2014 at 8:13 PM, Yury Gribov wrote: > Hi, > > Asan and Tsan allow sanitized applications to tweak runtime behavior via API > defined in headers in libsanitizer/include/sanitizer. This